Bug 234089 - Markup Pane not displaying.
Summary: Markup Pane not displaying.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-09 10:33 PST by Megan Gardner
Modified: 2021-12-09 15:28 PST (History)
8 users (show)

See Also:

Attachments
Patch (14.39 KB, patch)
2021-12-09 11:15 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (14.31 KB, patch)
2021-12-09 12:54 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (14.30 KB, patch)
2021-12-09 14:05 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (14.30 KB, patch)
2021-12-09 14:09 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2021-12-09 10:33:30 PST 
Get Markup Pane to display and in the proper location.
Comment 1 Megan Gardner 2021-12-09 11:15:45 PST 
Created attachment 446573 [details]
Patch
Comment 2 Tim Horton 2021-12-09 11:22:13 PST 
Comment on attachment 446573 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446573&action=review

> Source/WebCore/ChangeLog:3
> +        Get Markup Pane to display and in the proper location.

Title should describe the problem, not the fix

> Source/WebKit/Shared/ContextMenuContextData.cpp:74
> +    , m_controlledImageFrame(imageRect)

I know I said frame, but maybe go with "bounds"?

> Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:243
> +    auto webView = m_webView.get();

What is this about? you can just m_webView in all the places below.
Comment 3 Megan Gardner 2021-12-09 12:54:43 PST 
Created attachment 446592 [details]
Patch
Comment 4 Megan Gardner 2021-12-09 14:05:43 PST 
Created attachment 446603 [details]
Patch for landing
Comment 5 Megan Gardner 2021-12-09 14:09:28 PST 
Created attachment 446604 [details]
Patch for landing
Comment 6 EWS 2021-12-09 15:27:05 PST 
Committed r286812 (245048@main): <https://commits.webkit.org/245048@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446604 [details].
Comment 7 Radar WebKit Bug Importer 2021-12-09 15:28:23 PST 
<rdar://problem/86294041>