Bug 234085 - AX: Improve ASSERT while processing tree appends in AXIsolatedTree::applyPendingChanges
Summary: AX: Improve ASSERT while processing tree appends in AXIsolatedTree::applyPend...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-09 08:30 PST by Tyler Wilcock
Modified: 2021-12-09 15:21 PST (History)
10 users (show)

See Also:


Attachments
Patch (2.56 KB, patch)
2021-12-09 08:34 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2021-12-09 08:30:43 PST
The current assert:

ASSERT_UNUSED(addResult, addResult.iterator->value->refCount() == 2
            || (addResult.iterator->value.ptr() == m_rootNode.get() && m_rootNode->refCount() == 3));

Doesn't say what the refcount actually is, making it harder to debug. This was a problem for me when working on a previous patch.
Comment 1 Tyler Wilcock 2021-12-09 08:34:10 PST
Created attachment 446552 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-12-09 13:12:43 PST
<rdar://problem/86287382>
Comment 3 EWS 2021-12-09 15:21:54 PST
Committed r286811 (245047@main): <https://commits.webkit.org/245047@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446552 [details].