Bug 234082 - [CSS Cascade Layers] revert-layer should revert style attribute to regular author style
Summary: [CSS Cascade Layers] revert-layer should revert style attribute to regular au...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
: 233937 (view as bug list)
Depends on:
Blocks: 220779
  Show dependency treegraph
 
Reported: 2021-12-09 06:46 PST by Antti Koivisto
Modified: 2021-12-14 02:16 PST (History)
2 users (show)

See Also:


Attachments
Patch (9.52 KB, patch)
2021-12-09 06:52 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
Patch (9.48 KB, patch)
2021-12-09 06:54 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
Patch (16.24 KB, patch)
2021-12-13 02:10 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
Patch for landing (16.25 KB, patch)
2021-12-14 01:29 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-12-09 06:46:52 PST
It currently reverts to the next origin.
Comment 1 Antti Koivisto 2021-12-09 06:52:17 PST
Created attachment 446544 [details]
Patch
Comment 2 Antti Koivisto 2021-12-09 06:54:36 PST
Created attachment 446545 [details]
Patch
Comment 3 Antti Koivisto 2021-12-13 02:10:34 PST
Created attachment 446981 [details]
Patch
Comment 4 Antti Koivisto 2021-12-13 05:09:23 PST
*** Bug 233937 has been marked as a duplicate of this bug. ***
Comment 5 Simon Fraser (smfr) 2021-12-13 08:26:00 PST
Comment on attachment 446981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446981&action=review

> Source/WebCore/style/StyleBuilder.cpp:392
> +const PropertyCascade* Builder::ensureRollbackCascadeForRevertLayer()

Mixing the terms "rollback" and "revert" make my head hurt. Can this just be "ensureRevertCascade"? And use "revert" instead of "rollback" for the rest of the patch?
Comment 6 Antti Koivisto 2021-12-13 09:42:58 PST
> Mixing the terms "rollback" and "revert" make my head hurt. Can this just be
> "ensureRevertCascade"? And use "revert" instead of "rollback" for the rest
> of the patch?

The spec calls the operation performed by revert keywords "rolling back" as in

"If the cascaded value of a property is the revert-layer keyword, the cascaded value is rolled back to the layer below"

This is trying to keep with the spec terms.
Comment 7 EWS 2021-12-13 12:29:27 PST
Tools/Scripts/svn-apply failed to apply attachment 446981 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 8 Antti Koivisto 2021-12-14 01:29:15 PST
Created attachment 447116 [details]
Patch for landing
Comment 9 EWS 2021-12-14 02:15:03 PST
Committed r287018 (245223@main): <https://commits.webkit.org/245223@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447116 [details].
Comment 10 Radar WebKit Bug Importer 2021-12-14 02:16:20 PST
<rdar://problem/86458381>