Trying to debug a couple things on https://bug1653882.bmoattachments.org/attachment.cgi?id=9254233 using Release 136 (Safari 15.4, WebKit 16613.1.9.2) I keep getting "This webpage was reloaded because a problem occurred." It reproduces quite quickly when opening the Inspector for me. If not, you could also try mutating one of the nodes or running `onclick = console.log` in the Console. That usually did it for me.
<rdar://problem/86287498>
Infinite recursion in accessibility code. Reproduces for me after switching to Elements pane.
Created attachment 446945 [details] Patch
Created attachment 446946 [details] Patch
Created attachment 446947 [details] Patch
Comment on attachment 446947 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446947&action=review > LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups.html:-15 > - <div id="title-group" role="group" title="Oranges"> Is this a case we can still Cover? It seems like one of the reasons we made that original patch
(In reply to chris fleizach from comment #6) > Comment on attachment 446947 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=446947&action=review > > > LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups.html:-15 > > - <div id="title-group" role="group" title="Oranges"> > > Is this a case we can still > Cover? It seems like one of the reasons we made that original patch Yeah, looks like we use the title attribute in AccessibilityNodeObject::helpText which doesn't call accessibilityIsIgnored directly or indirectly. So I can add that back in.
Created attachment 447042 [details] Patch
Comment on attachment 447042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447042&action=review > LayoutTests/ChangeLog:16 > + shouldIgnoreGroup returns `true` if the group has one static text probably not necessary to include the entire justification again. you already have this in WebCore
Created attachment 447065 [details] Patch
Created attachment 447069 [details] Patch
Committed r287038 (245237@main): <https://commits.webkit.org/245237@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447069 [details].