Bug 234050 – Move SystemFontDatabaseCoreText to FontCache

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Cameron McCormack (:heycam)]

Move SystemFontDatabaseCoreText to FontCache

[Cameron McCormack (:heycam)]

Created attachment 446470 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 446470 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446470&action=review

> Source/WebCore/platform/graphics/FontCache.h:226
> +    SystemFontDatabaseCoreText m_systemFontDatabaseCoreText;

Is this going to compile on the non-Apple ports?

> Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:257
> +        result.fontName = AtomString("system-ui", AtomString::ConstructFromLiteral);

Don't we have a suffix that does this? Like "system-ui"_as or something?

[Cameron McCormack (:heycam)]

(In reply to Myles C. Maxfield from comment #2)
> > Source/WebCore/platform/graphics/FontCache.h:226
> > +    SystemFontDatabaseCoreText m_systemFontDatabaseCoreText;
> 
> Is this going to compile on the non-Apple ports?

It's in an existing #ifdef, just outside the patch context limit.

> > Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:257
> > +        result.fontName = AtomString("system-ui", AtomString::ConstructFromLiteral);
> 
> Don't we have a suffix that does this? Like "system-ui"_as or something?

We do.

[Radar WebKit Bug Importer]

<rdar://problem/86552964>

[Matt Woodrow]

Created attachment 461125 [details]
Patch

[EWS]

Committed 252770@main (c7d95cf25d9d): <https://commits.webkit.org/252770@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461125 [details].