Move SystemFontDatabaseCoreText to FontCache
Created attachment 446470 [details] Patch
Comment on attachment 446470 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446470&action=review > Source/WebCore/platform/graphics/FontCache.h:226 > + SystemFontDatabaseCoreText m_systemFontDatabaseCoreText; Is this going to compile on the non-Apple ports? > Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:257 > + result.fontName = AtomString("system-ui", AtomString::ConstructFromLiteral); Don't we have a suffix that does this? Like "system-ui"_as or something?
(In reply to Myles C. Maxfield from comment #2) > > Source/WebCore/platform/graphics/FontCache.h:226 > > + SystemFontDatabaseCoreText m_systemFontDatabaseCoreText; > > Is this going to compile on the non-Apple ports? It's in an existing #ifdef, just outside the patch context limit. > > Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:257 > > + result.fontName = AtomString("system-ui", AtomString::ConstructFromLiteral); > > Don't we have a suffix that does this? Like "system-ui"_as or something? We do.
<rdar://problem/86552964>
Created attachment 461125 [details] Patch
Committed 252770@main (c7d95cf25d9d): <https://commits.webkit.org/252770@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461125 [details].