Bug 234050 - Move SystemFontDatabaseCoreText to FontCache
Summary: Move SystemFontDatabaseCoreText to FontCache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks: 233488
  Show dependency treegraph
 
Reported: 2021-12-08 18:19 PST by Cameron McCormack (:heycam)
Modified: 2022-07-24 15:39 PDT (History)
6 users (show)

See Also:


Attachments
Patch (14.63 KB, patch)
2021-12-08 18:20 PST, Cameron McCormack (:heycam)
mmaxfield: review+
Details | Formatted Diff | Diff
Patch (13.74 KB, patch)
2022-07-21 15:18 PDT, Matt Woodrow
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-12-08 18:19:34 PST
Move SystemFontDatabaseCoreText to FontCache
Comment 1 Cameron McCormack (:heycam) 2021-12-08 18:20:48 PST
Created attachment 446470 [details]
Patch
Comment 2 Myles C. Maxfield 2021-12-10 15:14:12 PST
Comment on attachment 446470 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446470&action=review

> Source/WebCore/platform/graphics/FontCache.h:226
> +    SystemFontDatabaseCoreText m_systemFontDatabaseCoreText;

Is this going to compile on the non-Apple ports?

> Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:257
> +        result.fontName = AtomString("system-ui", AtomString::ConstructFromLiteral);

Don't we have a suffix that does this? Like "system-ui"_as or something?
Comment 3 Cameron McCormack (:heycam) 2021-12-10 15:28:06 PST
(In reply to Myles C. Maxfield from comment #2)
> > Source/WebCore/platform/graphics/FontCache.h:226
> > +    SystemFontDatabaseCoreText m_systemFontDatabaseCoreText;
> 
> Is this going to compile on the non-Apple ports?

It's in an existing #ifdef, just outside the patch context limit.

> > Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:257
> > +        result.fontName = AtomString("system-ui", AtomString::ConstructFromLiteral);
> 
> Don't we have a suffix that does this? Like "system-ui"_as or something?

We do.
Comment 4 Radar WebKit Bug Importer 2021-12-15 18:21:24 PST
<rdar://problem/86552964>
Comment 5 Matt Woodrow 2022-07-21 15:18:23 PDT
Created attachment 461125 [details]
Patch
Comment 6 EWS 2022-07-24 15:39:09 PDT
Committed 252770@main (c7d95cf25d9d): <https://commits.webkit.org/252770@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461125 [details].