Move FontFamilySpecificationCoreText's fontMap to FontCache
Created attachment 446469 [details] Patch
Comment on attachment 446469 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446469&action=review > Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm:51 > + // FIXME: Should clear this on all workers. I think some members on the team prefer for FIXMEs to have Bugzilla links > Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:-39 > -struct FontFamilySpecificationKey { It's kind of sad that this has to live in a different file, far from its use. This cache isn't really reusable, and FontFamilySpecificationCoreText.cpp is already fairly focused and cohesive with this in it. Can you think of a way to keep this code closer to its use?
The obvious thing would be to make the HashMap be heap allocated and then there'd be no need for the hash traits to be in a header. What do you think of the balance of having the HashMap be in a heap allocation versus keeping it all in the same file?
🤔
This doesn't seem worth a heap allocation, I think
<rdar://problem/86552797>
Created attachment 461073 [details] Patch
Committed 252710@main (498e08540016): <https://commits.webkit.org/252710@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461073 [details].