Bug 234037 – Refactoring: Make MediaPlayerEnums and HTMLMediaElementEnums namespaces rather than classes

• Status: NEW
• Component: Media

[Jer Noble]

Refactoring: Make MediaPlayerEnums and HTMLMediaElementEnums namespaces rather than classes

[Jer Noble]

Created attachment 446428 [details]
[fast-cq] Follow-up patch

[Jer Noble]

Created attachment 446434 [details]
Patch

[Eric Carlson]

Comment on attachment 446434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446434&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:1323
> -        m_networkState = NETWORK_LOADING;
> +        m_networkState = NetworkState::Idle;

This seems wrong.

> Source/WebCore/html/HTMLMediaElement.cpp:1460
> -    m_networkState = NETWORK_LOADING;
> +    m_networkState = NetworkState::Idle;

Ditto

> Source/WebCore/html/HTMLMediaElement.cpp:2320
> -        if (m_networkState < NETWORK_LOADING || m_networkState == NETWORK_NO_SOURCE)
> +        if (m_networkState < NetworkState::Idle || m_networkState == NetworkState::NoSource)

Ditto.

> Source/WebCore/html/HTMLMediaElement.cpp:2322
> -        m_networkState = NETWORK_LOADING;
> +        m_networkState = NetworkState::Idle;

Ditto.

> Source/WebCore/html/HTMLMediaElement.cpp:2918
> -    if (m_networkState != NETWORK_LOADING)
> +    if (m_networkState != NetworkState::Idle)

Ditto

> Source/WebCore/html/HTMLMediaElement.cpp:3928
> -    return !paused() && m_networkState == NETWORK_LOADING && m_readyState <= HAVE_CURRENT_DATA;
> +    return !paused() && m_networkState == NetworkState::Idle && m_readyState <= ReadyState::HaveCurrentData;

Ditto

> Source/WebCore/html/HTMLMediaElement.cpp:3943
> -    return !paused() && m_networkState == NETWORK_LOADING && m_readyState <= HAVE_CURRENT_DATA && m_sentStalledEvent;
> +    return !paused() && m_networkState == NetworkState::Idle && m_readyState <= ReadyState::HaveCurrentData && m_sentStalledEvent;

Ditto

> Source/WebCore/html/HTMLMediaElement.cpp:4932
> -    m_networkState = NETWORK_LOADING;
> +    m_networkState = NetworkState::Idle;

Ditto.

> Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.h:84
> +        MediaPlayerEnums::VideoFullscreenMode mode() const { return m_mode; }

Nit: extra indentation

[Radar WebKit Bug Importer]

<rdar://problem/86543781>