RESOLVED FIXED234026
[MSE] Add a Modules/mediasource/README.md file 
https://bugs.webkit.org/show_bug.cgi?id=234026
Summary [MSE] Add a Modules/mediasource/README.md file
Jer Noble
Reported 2021-12-08 12:04:33 PST
[MSE] Add a Modules/mediasource/README.md file
Attachments
Patch (6.55 KB, patch)
2021-12-08 12:05 PST, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (6.55 KB, patch)
2021-12-08 12:43 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
[fast-cq] Follow-up patch (4.29 KB, patch)
2021-12-08 14:28 PST, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
[fast-cq] Follow-up patch (4.28 KB, patch)
2021-12-08 14:55 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-12-08 12:05:38 PST
Created attachment 446404 [details] Patch
Eric Carlson
Comment 2 2021-12-08 12:30:36 PST
Comment on attachment 446404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446404&action=review > Source/WebCore/Modules/mediasource/README.md:7 > +The Media Source Extensions specification defines a set of classes which allows clients to implement their own loading, buffering, and variant switching behavior, as opposed to allowing the UA to handle same. Maybe "as opposed to requiring the UA to" instead of "allowing"? > Source/WebCore/Modules/mediasource/README.md:59 > +MediaSample is an abstract base class representing a sample parsed from a media segment. MediaSamples have `presentationTime()`, `decodeTime()`, and `duration()`, which are used to order these samples relative to one another in a [SampleMap](#samplemap). For codecs which support frame reordering, `presentationTime()` and `decodeTime()` for each sample may differ. It is probably worth mentioning `MediaTime`, and why we use it instead of `double` for time values..
Peng Liu
Comment 3 2021-12-08 12:38:23 PST
Comment on attachment 446404 [details] Patch I like this patch! View in context: https://bugs.webkit.org/attachment.cgi?id=446404&action=review > Source/WebCore/Modules/mediasource/README.md:54 > + Maybe we can add some information about SourceBufferPrivateAVFObjC and SourceBufferParser?
Jer Noble
Comment 4 2021-12-08 12:43:11 PST
Created attachment 446412 [details] Patch for landing
Jer Noble
Comment 5 2021-12-08 12:43:40 PST
(In reply to Peng Liu from comment #3) > Comment on attachment 446404 [details] > Patch > > I like this patch! > > View in context: > https://bugs.webkit.org/attachment.cgi?id=446404&action=review > > > Source/WebCore/Modules/mediasource/README.md:54 > > + > > Maybe we can add some information about SourceBufferPrivateAVFObjC and > SourceBufferParser? Good idea! I'll do that in a follow-up patch.
EWS
Comment 6 2021-12-08 13:40:26 PST
Committed r286738 (244988@main): <https://commits.webkit.org/244988@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446412 [details].
Radar WebKit Bug Importer
Comment 7 2021-12-08 13:41:21 PST
<rdar://problem/86227732>
Jer Noble
Comment 8 2021-12-08 14:27:58 PST
Reopening to attach new patch.
Jer Noble
Comment 9 2021-12-08 14:28:00 PST
Created attachment 446421 [details] [fast-cq] Follow-up patch
EWS
Comment 10 2021-12-08 14:38:27 PST
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Jer Noble
Comment 11 2021-12-08 14:55:45 PST
Created attachment 446430 [details] [fast-cq] Follow-up patch
EWS
Comment 12 2021-12-08 14:58:52 PST
Committed r286742 (244989@main): <https://commits.webkit.org/244989@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446430 [details].
Note You need to log in before you can comment on or make changes to this bug.