Bug 234022 - Prepare for transition to C++20
Summary: Prepare for transition to C++20
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-08 11:31 PST by Alex Christensen
Modified: 2021-12-09 16:26 PST (History)
23 users (show)

See Also:

Attachments
Patch (92.48 KB, patch)
2021-12-08 11:38 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (87.38 KB, patch)
2021-12-08 16:40 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (86.73 KB, patch)
2021-12-09 15:11 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-12-08 11:31:16 PST 
Prepare for transition to C++20
Comment 1 Alex Christensen 2021-12-08 11:38:49 PST 
Created attachment 446397 [details]
Patch
Comment 2 Alex Christensen 2021-12-08 16:40:28 PST 
Created attachment 446455 [details]
Patch
Comment 3 Yusuke Suzuki 2021-12-09 14:38:28 PST 
Comment on attachment 446455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446455&action=review

r=me with one fix.

> Tools/TestWebKitAPI/Tests/WTF/Expected.cpp:-297
> -    NonCopyable(NonCopyable&&) = default;
> -    NonCopyable(const NonCopyable&) = delete;
> -    NonCopyable& operator=(const NonCopyable&) = delete;
> -    NonCopyable& operator=(NonCopyable&&) = default;

We should use `WTF_MAKE_NONCOPYABLE` here to make it noncopyable.
Comment 4 Alex Christensen 2021-12-09 15:11:36 PST 
Created attachment 446618 [details]
Patch
Comment 5 Alex Christensen 2021-12-09 15:47:49 PST 
Comment on attachment 446618 [details]
Patch

For some reason that didn't compile.  I removed that change from this patch.
Comment 6 Alex Christensen 2021-12-09 16:25:36 PST 
http://trac.webkit.org/r286816
Comment 7 Radar WebKit Bug Importer 2021-12-09 16:26:22 PST 
<rdar://problem/86296640>