...
rdar://86140542
Created attachment 446392 [details] Patch
Comment on attachment 446392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446392&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:445 > +@property (nonatomic, readwrite, setter=_setFindInteractionEnabled:) BOOL _findInteractionEnabled WK_API_AVAILABLE(ios(WK_IOS_TBA)); There was some discussion about whether this should be here (on WKWebView) or WKPreferences. We (Geoff, Tim, Aditya, Alex and I) chatted about this over Slack, and I *think* we all eventually came to the conclusion that this property should go on WKWebView itself, since setting this has side effects beyond just changing the value of a flag (and so calling `-_setFindInteractionEnabled:` is, in a way, performing an action on the web view). If it were only changing the flag's value, then I think we would put this on WKPreferences, like most of the other API/SPI flags.
Committed r286823 (245057@main): <https://commits.webkit.org/245057@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446392 [details].
Comment on attachment 446392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446392&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:457 > + RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:CGRectMake(0, 0, 200, 200)]); Not critical to fix, but this could be: auto webView = ... or: RetainPtr webView = ... Either of those seems slightly nicer.