Bug 234012 - Web Inspector: After r286657, anonymous layers are providing an empty string for their grouping text
Summary: Web Inspector: After r286657, anonymous layers are providing an empty string ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on: 231340
Blocks:
  Show dependency tree / graph
 
Reported: 2021-12-08 09:02 PST by Patrick Angle
Modified: 2021-12-14 14:06 PST (History)
5 users (show)

See Also:

Attachments
Patch v1.0 (3.60 KB, patch)
2021-12-08 15:32 PST, Patrick Angle 		no flags Details | Formatted Diff | Diff
Patch v1.1 (2.05 KB, patch)
2021-12-14 12:43 PST, Patrick Angle 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2021-12-08 09:02:50 PST 
The frontend makes the assumption that text will only be provided for named layers, and that anonymous layers will instead forgo setting the `text` for the grouping payload. We either need to conditionalize setting the text, or handle empty strings in the frontend, not just undefined strings.
Comment 1 Radar WebKit Bug Importer 2021-12-08 09:03:08 PST 
<rdar://problem/86214025>
Comment 2 Patrick Angle 2021-12-08 15:32:53 PST 
Created attachment 446439 [details]
Patch v1.0
Comment 3 Patrick Angle 2021-12-14 12:43:19 PST 
Created attachment 447148 [details]
Patch v1.1
Comment 4 Devin Rousso 2021-12-14 12:51:52 PST 
Comment on attachment 447148 [details]
Patch v1.1

rs=me
Comment 5 EWS 2021-12-14 14:06:08 PST 
Committed r287046 (245243@main): <https://commits.webkit.org/245243@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447148 [details].