Bug 233994 - GraphicsContextGLANGLE delivers context lost twice when reshape fails
Summary: GraphicsContextGLANGLE delivers context lost twice when reshape fails
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: gcgranglecleanup
  Show dependency tree / graph
 
Reported: 2021-12-08 01:43 PST by Kimmo Kinnunen
Modified: 2021-12-15 01:44 PST (History)
9 users (show)

See Also:

Attachments
Patch (10.78 KB, patch)
2021-12-08 01:51 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (10.75 KB, patch)
2021-12-08 02:09 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (18.15 KB, patch)
2021-12-08 03:17 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for EWS (18.20 KB, patch)
2021-12-08 12:16 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-12-08 01:43:22 PST 
GraphicsContextGLANGLE delivers context lost twice when reshape fails
Comment 1 Kimmo Kinnunen 2021-12-08 01:51:07 PST 
Created attachment 446334 [details]
Patch
Comment 2 Antti Koivisto 2021-12-08 01:56:14 PST 
Comment on attachment 446334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446334&action=review

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:387
> +    // Returns true on success.
>      bool reshapeFBOs(const IntSize&);

enum class return type would requires less explanations

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:400
> -    // Returns false if context should be lost due to timeout.
> +    // Returns true on success. Returns false if context should be lost due to timeout.
>      bool waitAndUpdateOldestFrame() WARN_UNUSED_RETURN;

here too
Comment 3 Kimmo Kinnunen 2021-12-08 02:09:02 PST 
Created attachment 446337 [details]
Patch for landing
Comment 4 Kimmo Kinnunen 2021-12-08 03:17:37 PST 
Created attachment 446345 [details]
Patch for landing
Comment 5 Kimmo Kinnunen 2021-12-08 12:16:45 PST 
Created attachment 446408 [details]
Patch for EWS
Comment 6 Radar WebKit Bug Importer 2021-12-15 01:44:18 PST 
<rdar://problem/86512404>