Bug 233994 – GraphicsContextGLANGLE delivers context lost twice when reshape fails

• Status: ASSIGNED
• Component: WebGL

[Kimmo Kinnunen]

GraphicsContextGLANGLE delivers context lost twice when reshape fails

[Kimmo Kinnunen]

Created attachment 446334 [details]
Patch

[Antti Koivisto]

Comment on attachment 446334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446334&action=review

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:387
> +    // Returns true on success.
>      bool reshapeFBOs(const IntSize&);

enum class return type would requires less explanations

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:400
> -    // Returns false if context should be lost due to timeout.
> +    // Returns true on success. Returns false if context should be lost due to timeout.
>      bool waitAndUpdateOldestFrame() WARN_UNUSED_RETURN;

here too

[Kimmo Kinnunen]

Created attachment 446337 [details]
Patch for landing

[Kimmo Kinnunen]

Created attachment 446345 [details]
Patch for landing

[Kimmo Kinnunen]

Created attachment 446408 [details]
Patch for EWS

[Radar WebKit Bug Importer]

<rdar://problem/86512404>