Bug 233984 - Make FontCache allowlist thread safe
Summary: Make FontCache allowlist thread safe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks: 233488
  Show dependency tree / graph
 
Reported: 2021-12-07 23:00 PST by Cameron McCormack (:heycam)
Modified: 2022-07-20 14:22 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.59 KB, patch)
2021-12-07 23:01 PST, Cameron McCormack (:heycam) 		mmaxfield: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (3.29 KB, patch)
2022-07-19 22:12 PDT, Matt Woodrow 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-12-07 23:00:55 PST 
Make FontCache allowlist thread safe
Comment 1 Cameron McCormack (:heycam) 2021-12-07 23:01:55 PST 
Created attachment 446310 [details]
Patch
Comment 2 Myles C. Maxfield 2021-12-10 14:49:11 PST 
Comment on attachment 446310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446310&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1225
> +    Locker locker { Allowlist::lock };

This might be an opportunity for performance improvement, since this allowlist is only used for testing.
Comment 3 Radar WebKit Bug Importer 2021-12-14 23:01:24 PST 
<rdar://problem/86507543>
Comment 4 Matt Woodrow 2022-07-19 22:12:45 PDT 
Created attachment 461035 [details]
Patch
Comment 5 EWS 2022-07-20 14:22:02 PDT 
Committed 252657@main (af751da03e16): <https://commits.webkit.org/252657@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461035 [details].