Bug 233982 - Add isMainThread() assertions to specializedChineseLocale
Summary: Add isMainThread() assertions to specializedChineseLocale
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks: 233488
  Show dependency tree / graph
 
Reported: 2021-12-07 22:52 PST by Cameron McCormack (:heycam)
Modified: 2022-07-19 23:03 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.91 KB, patch)
2021-12-07 22:53 PST, Cameron McCormack (:heycam) 		mmaxfield: review+
Details | Formatted Diff | Diff
Patch (2.82 KB, patch)
2022-07-19 15:50 PDT, Matt Woodrow 		no flags Details | Formatted Diff | Diff
Patch (2.87 KB, patch)
2022-07-19 17:31 PDT, Matt Woodrow 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-12-07 22:52:52 PST 
Add isMainThread() assertions to specializedChineseLocale
Comment 1 Cameron McCormack (:heycam) 2021-12-07 22:53:53 PST 
Created attachment 446307 [details]
Patch
Comment 2 Myles C. Maxfield 2021-12-08 21:14:46 PST 
Comment on attachment 446307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446307&action=review

> Source/WebCore/platform/graphics/FontDescription.cpp:103
>  void FontDescription::setSpecifiedLocale(const AtomString& locale)

It looks like this function is exported, but no one outside of WebCore calls it. Can we make it not exported?
Comment 3 Radar WebKit Bug Importer 2021-12-14 22:53:15 PST 
<rdar://problem/86507335>
Comment 4 Matt Woodrow 2022-07-19 15:50:12 PDT 
Created attachment 461023 [details]
Patch
Comment 5 Yusuke Suzuki 2022-07-19 16:49:46 PDT 
BTW, you can use MainThreadNeverDestroyed for NeverDestoryed objects which is available only in MainThread.
Comment 6 Matt Woodrow 2022-07-19 17:31:05 PDT 
Created attachment 461026 [details]
Patch
Comment 7 EWS 2022-07-19 23:03:24 PDT 
Committed 252637@main (5ba8177f9530): <https://commits.webkit.org/252637@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461026 [details].