Bug 233964 – Avoid noisy Wcomment warnings after ANGLE update in r286603

• Status: RESOLVED
• Resolution: FIXED
• Component: ANGLE

[Lauro Moura]

Avoid noisy Wcomment warnings after ANGLE update in r286603

[Lauro Moura]

Created attachment 446268 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[EWS]

Committed r286636 (244949@main): <https://commits.webkit.org/244949@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446268 [details].

[Radar WebKit Bug Importer]

<rdar://problem/86186455>

[Adrian Perez]

I still see a number of similar warnings, at least in
RewriteArrayOfArrayOfOpaqueUniforms.cpp and RewriteStructSamplers.cpp;
there might be more lurking around if one does a clean build:

[269/7571] Building CXX object Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/compiler/translator/tree_ops/RewriteArrayOfArrayOfOpaqueUniforms.cpp.o
/app/webkit/Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/RewriteArrayOfArrayOfOpaqueUniforms.cpp:107:1: warning: multi-line comment [-Wcomment]
107 | //                                                    /           \
    | ^
...
[285/7571] Building CXX object Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/compiler/translator/tree_ops/RewriteStructSamplers.cpp.o
/app/webkit/Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/RewriteStructSamplers.cpp:169:1: warning: multi-line comment [-Wcomment]
169 | //                                                    /                  \
    | ^
...

Wouldn't it have been better to tell CMake to pass -Wno-comment when
building ANGLE sources? Also Lauro's patch modifies an ANGLE source
file without updating Source/ThirdParty/ANGLE/changes.diff 🤔️

If possible, we should aim to have as little local changes on top of
upstream ANGLE as possible.

[Adrian Perez]

Created attachment 446324 [details]
Patch

[Lauro Moura]

(In reply to Adrian Perez from comment #6)
> Created attachment 446324 [details]
> Patch

Testing locally, all good. No warnings (and no changed upstream files... 🙈).

[EWS]

Committed r286659 (244972@main): <https://commits.webkit.org/244972@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446324 [details].