Bug 233964 - Avoid noisy Wcomment warnings after ANGLE update in r286603
Summary: Avoid noisy Wcomment warnings after ANGLE update in r286603
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-07 17:33 PST by Lauro Moura
Modified: 2021-12-08 09:08 PST (History)
14 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2021-12-07 17:36 PST, Lauro Moura 		no flags Details | Formatted Diff | Diff
Patch (3.59 KB, patch)
2021-12-08 00:20 PST, Adrian Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-12-07 17:33:40 PST 
Avoid noisy Wcomment warnings after ANGLE update in r286603
Comment 1 Lauro Moura 2021-12-07 17:36:24 PST 
Created attachment 446268 [details]
Patch
Comment 2 EWS Watchlist 2021-12-07 17:37:47 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 EWS 2021-12-07 18:10:49 PST 
Committed r286636 (244949@main): <https://commits.webkit.org/244949@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446268 [details].
Comment 4 Radar WebKit Bug Importer 2021-12-07 18:11:51 PST 
<rdar://problem/86186455>
Comment 5 Adrian Perez 2021-12-07 23:57:00 PST 
I still see a number of similar warnings, at least in
RewriteArrayOfArrayOfOpaqueUniforms.cpp and RewriteStructSamplers.cpp;
there might be more lurking around if one does a clean build:

[269/7571] Building CXX object Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/compiler/translator/tree_ops/RewriteArrayOfArrayOfOpaqueUniforms.cpp.o
/app/webkit/Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/RewriteArrayOfArrayOfOpaqueUniforms.cpp:107:1: warning: multi-line comment [-Wcomment]
107 | //                                                    /           \
    | ^
...
[285/7571] Building CXX object Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/compiler/translator/tree_ops/RewriteStructSamplers.cpp.o
/app/webkit/Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/RewriteStructSamplers.cpp:169:1: warning: multi-line comment [-Wcomment]
169 | //                                                    /                  \
    | ^
...

Wouldn't it have been better to tell CMake to pass -Wno-comment when
building ANGLE sources? Also Lauro's patch modifies an ANGLE source
file without updating Source/ThirdParty/ANGLE/changes.diff 🤔️

If possible, we should aim to have as little local changes on top of
upstream ANGLE as possible.
Comment 6 Adrian Perez 2021-12-08 00:20:52 PST 
Created attachment 446324 [details]
Patch
Comment 7 Lauro Moura 2021-12-08 07:02:55 PST 
(In reply to Adrian Perez from comment #6)
> Created attachment 446324 [details]
> Patch

Testing locally, all good. No warnings (and no changed upstream files... 🙈).
Comment 8 EWS 2021-12-08 09:07:58 PST 
Committed r286659 (244972@main): <https://commits.webkit.org/244972@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446324 [details].