Bug 233959 - Add DOMStructures
Summary: Add DOMStructures
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 233918
Blocks:
  Show dependency tree / graph
 
Reported: 2021-12-07 16:43 PST by Yusuke Suzuki
Modified: 2024-03-23 18:32 PDT (History)
15 users (show)

See Also:

Attachments
WIP (132.46 KB, patch)
2022-02-23 00:31 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP (132.95 KB, patch)
2022-02-23 01:10 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP (132.25 KB, patch)
2022-02-23 01:37 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP (131.76 KB, patch)
2022-02-23 01:58 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-12-07 16:43:32 PST 
We should have the same mechanism to DOMConstructors: DOMStructures array.
Now, we have significantly better / faster StructureID implementation. And WriteBarrierStructureID (sizeof(WriteBarrierStructureID) is 4!) is coming.
We should have std::array<WriteBarrierStructureID, numberOfStructures> instead of HashMap<ClassInfo*, WriteBarrier<Structure>>, which is faster. And maybe it is more compact (HashMap allocates roughly 4x memory usually, we do not need to have ClassInfo*, and we do not need to hold Structure*).
Comment 1 Radar WebKit Bug Importer 2021-12-14 16:44:17 PST 
<rdar://problem/86496457>
Comment 2 Yusuke Suzuki 2022-02-23 00:31:36 PST 
Created attachment 452945 [details]
WIP
Comment 3 Yusuke Suzuki 2022-02-23 01:10:36 PST 
Created attachment 452949 [details]
WIP
Comment 4 Yusuke Suzuki 2022-02-23 01:37:55 PST 
Created attachment 452951 [details]
WIP
Comment 5 Yusuke Suzuki 2022-02-23 01:58:20 PST 
Created attachment 452952 [details]
WIP
Comment 6 Yusuke Suzuki 2024-03-23 18:32:15 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/26381