Bug 233954 - Make KVO work for WKWebpagePreferences._captivePortalModeEnabled
Summary: Make KVO work for WKWebpagePreferences._captivePortalModeEnabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-07 14:22 PST by Chris Dumez
Modified: 2021-12-08 10:05 PST (History)
7 users (show)

See Also:

Attachments
Patch (48.57 KB, patch)
2021-12-07 14:29 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (48.86 KB, patch)
2021-12-07 16:37 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (49.18 KB, patch)
2021-12-08 09:46 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-12-07 14:22:55 PST 
Make KVO work for WKWebpagePreferences._captivePortalModeEnabled so that the client can observe when the system setting changes.
Comment 1 Chris Dumez 2021-12-07 14:29:11 PST 
Created attachment 446237 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-12-07 16:31:47 PST 
<rdar://problem/86182490>
Comment 3 Chris Dumez 2021-12-07 16:37:42 PST 
Created attachment 446253 [details]
Patch
Comment 4 Alex Christensen 2021-12-08 09:09:02 PST 
Comment on attachment 446253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446253&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm:125
> +#if USE(APPLE_INTERNAL_SDK)

Why?
Also, I don't see an implementation of this.

> Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm:138
> +    id m_object;

WeakObjCPtr<id>
Comment 5 Chris Dumez 2021-12-08 09:10:54 PST 
(In reply to Alex Christensen from comment #4)
> Comment on attachment 446253 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=446253&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm:125
> > +#if USE(APPLE_INTERNAL_SDK)
> 
> Why?
> Also, I don't see an implementation of this.

Please see corresponding patch in Internal.

> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm:138
> > +    id m_object;
> 
> WeakObjCPtr<id>

Ok.
Comment 6 Wenson Hsieh 2021-12-08 09:14:09 PST 
Comment on attachment 446253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446253&action=review

>>> Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm:125
>>> +#if USE(APPLE_INTERNAL_SDK)
>> 
>> Why?
>> Also, I don't see an implementation of this.
> 
> Please see corresponding patch in Internal.

FWIW, `USE(APPLE_INTERNAL_SDK)` is typically only used to guard WKA header includes. You could do something here like:

```
#if USE(APPLE_INTERNAL_SDK)
// include the WKA header
#else
// define empty method stubs
#endif
```

…and then avoid having to use `USE(APPLE_INTERNAL_SDK)` here.
Comment 7 Chris Dumez 2021-12-08 09:46:25 PST 
Created attachment 446379 [details]
Patch
Comment 8 Chris Dumez 2021-12-08 10:05:05 PST 
Comment on attachment 446379 [details]
Patch

Clearing flags on attachment: 446379

Committed r286661 (?): <https://commits.webkit.org/r286661>
Comment 9 Chris Dumez 2021-12-08 10:05:08 PST 
All reviewed patches have been landed.  Closing bug.