Bug 23394 - Remove calls to WebCore::setDeferringTimers()
Summary: Remove calls to WebCore::setDeferringTimers()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-16 15:16 PST by Dmitry Titov
Modified: 2009-01-16 15:27 PST (History)
2 users (show)

See Also:


Attachments
Proposed patch (1.70 KB, patch)
2009-01-16 15:18 PST, Dmitry Titov
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2009-01-16 15:16:01 PST
ResourceHandleManager for curl disables global timers during select() call to avoid being interrupted by a process signal. It appears that original effort to fix the interruption ended up using also a loop in case 'select' returns with EINTR. Loop is the sufficient way to deal with interruptions (for example, see here: http://www.wlug.org.nz/EINTR). See bug 16071 for more info.

I'm removing setDeferringTimers() because nothing else uses it and I'm in the process of making TimerBase thread-aware for workers.
Comment 1 Dmitry Titov 2009-01-16 15:18:57 PST
Created attachment 26811 [details]
Proposed patch
Comment 2 Alp Toker 2009-01-16 15:22:52 PST
Comment on attachment 26811 [details]
Proposed patch

r=me
Comment 3 Alp Toker 2009-01-16 15:27:15 PST
Landed in r39991, thanks for the cleanup. Please remember to follow up soon with a bug/patch that removes the unused code.