Bug 233932 - ActiveDOMObject::suspendIfNeeded() should not be called in the WebAnimation constructor
Summary: ActiveDOMObject::suspendIfNeeded() should not be called in the WebAnimation c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-07 09:38 PST by Antoine Quint
Modified: 2021-12-07 22:31 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.84 KB, patch)
2021-12-07 09:39 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (5.63 KB, patch)
2021-12-07 13:12 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2021-12-07 09:38:20 PST
ActiveDOMObject::suspendIfNeeded() should not be called in the WebAnimation constructor
Comment 1 Antoine Quint 2021-12-07 09:39:24 PST
Created attachment 446191 [details]
Patch
Comment 2 Chris Dumez 2021-12-07 09:40:15 PST
Comment on attachment 446191 [details]
Patch

r=me
Comment 3 Antoine Quint 2021-12-07 12:54:11 PST
I know what's wrong with the mac-AS-debug-wk2 bot, moving the call to suspendIfNeeded() in the WebAnimation::create() calls means that WebAnimation subclasses are no longer calling suspendIfNeeded().
Comment 4 Antoine Quint 2021-12-07 13:12:32 PST
Created attachment 446227 [details]
Patch
Comment 5 EWS 2021-12-07 22:30:08 PST
Committed r286642 (244955@main): <https://commits.webkit.org/244955@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446227 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-07 22:31:19 PST
<rdar://problem/86192916>