Bug 23392 - Some pixel test output includes DumpRenderTree warnings about changing main display profile
Summary: Some pixel test output includes DumpRenderTree warnings about changing main d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Pierre-Olivier Latour
URL: http://build.webkit.org/results/trunk...
Keywords: LayoutTestFailure, Regression
Depends on:
Blocks:
 
Reported: 2009-01-16 14:55 PST by David Kilzer (:ddkilzer)
Modified: 2009-03-02 11:51 PST (History)
1 user (show)

See Also:


Attachments
Patch v1 (2.31 KB, patch)
2009-01-20 15:38 PST, Pierre-Olivier Latour
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2009-01-16 14:55:37 PST
* SUMMARY
Some pixel tests (the first test each time DumpRenderTree is restarted) contain bogus STDERR output about changing the main display profile.  This shouldn't be included in the test output.

* STEPS TO REPRODUCE
$ ./WebKitTools/Scripts/run-webkit-tests --pixel --singly

* RESULTS
Every test will have STDERR output because a new DumpRenderTree process is created for each test via the "--singly" flag.  This should be printed to the console instead.

* REGRESSION
This probably started when STDERR output begin to be captured for all tests.  This warning used to get printed to the console.

* NOTES
The warning message:

WARNING: Temporarily changing the main display color profile to "/System/Library/ColorSync/Profiles/Generic RGB Profile.icc": the colors on your screen will change for the duration of the testing.
This allows the WebKit pixel-based regression tests to have consistent color values across all machines.
Comment 1 David Kilzer (:ddkilzer) 2009-01-16 14:56:35 PST
One solution would be to prefix all DumpRenderTree output with a unique string (like "DRT: ") so that run-webkit-tests knows that it should print those lines out to the console (instead of including them as part of the test output).
Comment 2 Pierre-Olivier Latour 2009-01-20 08:32:47 PST
Why don't we just remove this warning? I left it in place when I re-implement the pixel test path of DRT, but never though it had any added value.
Comment 3 mitz 2009-01-20 08:40:15 PST
(In reply to comment #1)
> One solution would be to prefix all DumpRenderTree output with a unique string
> (like "DRT: ") so that run-webkit-tests knows that it should print those lines
> out to the console (instead of including them as part of the test output).

I think a simpler solution would be for the script, instead of DRT, to output this message. But I am fine with removing it altogether.
Comment 4 David Kilzer (:ddkilzer) 2009-01-20 10:14:26 PST
(In reply to comment #3)
> I think a simpler solution would be for the script, instead of DRT, to output
> this message. But I am fine with removing it altogether.

Ditto.
Comment 5 Pierre-Olivier Latour 2009-01-20 15:38:33 PST
Created attachment 26875 [details]
Patch v1
Comment 6 Darin Adler 2009-01-20 16:07:36 PST
Comment on attachment 26875 [details]
Patch v1

Seems OK, r=me
Comment 7 Pierre-Olivier Latour 2009-01-20 16:30:51 PST
Sending        WebKitTools/ChangeLog
Sending        WebKitTools/DumpRenderTree/mac/PixelDumpSupportMac.mm
Sending        WebKitTools/Scripts/run-webkit-tests
Transmitting file data ...
Committed revision 40075.