Bug 23392 – Some pixel test output includes DumpRenderTree warnings about changing main display profile

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

* SUMMARY
Some pixel tests (the first test each time DumpRenderTree is restarted) contain bogus STDERR output about changing the main display profile.  This shouldn't be included in the test output.

* STEPS TO REPRODUCE
$ ./WebKitTools/Scripts/run-webkit-tests --pixel --singly

* RESULTS
Every test will have STDERR output because a new DumpRenderTree process is created for each test via the "--singly" flag.  This should be printed to the console instead.

* REGRESSION
This probably started when STDERR output begin to be captured for all tests.  This warning used to get printed to the console.

* NOTES
The warning message:

WARNING: Temporarily changing the main display color profile to "/System/Library/ColorSync/Profiles/Generic RGB Profile.icc": the colors on your screen will change for the duration of the testing.
This allows the WebKit pixel-based regression tests to have consistent color values across all machines.

[David Kilzer (:ddkilzer)]

One solution would be to prefix all DumpRenderTree output with a unique string (like "DRT: ") so that run-webkit-tests knows that it should print those lines out to the console (instead of including them as part of the test output).

[Pierre-Olivier Latour]

Why don't we just remove this warning? I left it in place when I re-implement the pixel test path of DRT, but never though it had any added value.

(In reply to comment #1)
> One solution would be to prefix all DumpRenderTree output with a unique string
> (like "DRT: ") so that run-webkit-tests knows that it should print those lines
> out to the console (instead of including them as part of the test output).

I think a simpler solution would be for the script, instead of DRT, to output this message. But I am fine with removing it altogether.

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> I think a simpler solution would be for the script, instead of DRT, to output
> this message. But I am fine with removing it altogether.

Ditto.

[Pierre-Olivier Latour]

Created attachment 26875 [details]
Patch v1

[Darin Adler]

Comment on attachment 26875 [details]
Patch v1

Seems OK, r=me

[Pierre-Olivier Latour]

Sending        WebKitTools/ChangeLog
Sending        WebKitTools/DumpRenderTree/mac/PixelDumpSupportMac.mm
Sending        WebKitTools/Scripts/run-webkit-tests
Transmitting file data ...
Committed revision 40075.