Bug 233903 - Add web push message decryption routines
Summary: Add web push message decryption routines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-06 16:56 PST by Ben Nham
Modified: 2022-01-29 21:22 PST (History)
10 users (show)

See Also:

Attachments
Patch (45.98 KB, patch)
2021-12-06 16:58 PST, Ben Nham 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (46.20 KB, patch)
2021-12-06 17:05 PST, Ben Nham 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (46.24 KB, patch)
2021-12-06 17:16 PST, Ben Nham 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (46.13 KB, patch)
2021-12-06 19:40 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch (46.16 KB, patch)
2021-12-06 20:41 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch (51.10 KB, patch)
2021-12-06 22:11 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch (51.18 KB, patch)
2021-12-13 23:14 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch (39.17 KB, patch)
2021-12-13 23:19 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Add unit tests that were left out of original patch for landing (12.01 KB, patch)
2022-01-29 11:53 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2021-12-06 16:56:26 PST 
Add web push message decryption routines
Comment 1 Ben Nham 2021-12-06 16:58:23 PST 
Created attachment 446100 [details]
Patch
Comment 2 Ben Nham 2021-12-06 17:05:18 PST 
Created attachment 446102 [details]
Patch
Comment 3 Ben Nham 2021-12-06 17:16:12 PST 
Created attachment 446105 [details]
Patch
Comment 4 Ben Nham 2021-12-06 19:40:19 PST 
Created attachment 446113 [details]
Patch
Comment 5 Ben Nham 2021-12-06 20:41:04 PST 
Created attachment 446117 [details]
Patch
Comment 6 Ben Nham 2021-12-06 22:11:57 PST 
Created attachment 446121 [details]
Patch
Comment 7 Radar WebKit Bug Importer 2021-12-07 08:40:48 PST 
<rdar://problem/86158111>
Comment 8 Brady Eidson 2021-12-13 16:38:09 PST 
Comment on attachment 446121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446121&action=review

> Source/WebCore/Modules/push-api/PushCrypto.cpp:35
> +namespace WebCore {
> +
> +namespace PushCrypto {

namespace WebCore::PushCrypto {

> Source/WebCore/Modules/push-api/PushCrypto.h:36
> +namespace WebCore {
> +
> +namespace PushCrypto {

namespace WebCore::PushCrypto {

> Source/WebCore/Modules/push-api/PushMessageCrypto.cpp:37
> +namespace WebCore {
> +
> +namespace PushCrypto {

namespace WebCore::PushCrypto {

> Source/WebCore/Modules/push-api/PushMessageCrypto.h:37
> +namespace WebCore {
> +
> +namespace PushCrypto {

namespace WebCore::PushCrypto {

> Source/WebCore/Modules/push-api/cocoa/PushCryptoCocoa.cpp:37
> +namespace WebCore {
> +
> +namespace PushCrypto {

namespace WebCore::PushCrypto {
Comment 9 Ben Nham 2021-12-13 23:14:06 PST 
Created attachment 447110 [details]
Patch
Comment 10 Ben Nham 2021-12-13 23:19:45 PST 
Created attachment 447111 [details]
Patch
Comment 11 EWS 2021-12-14 00:19:11 PST 
Committed r287015 (245220@main): <https://commits.webkit.org/245220@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447111 [details].
Comment 12 Ben Nham 2022-01-29 11:53:17 PST 
Reopening to attach new patch.
Comment 13 Ben Nham 2022-01-29 11:53:19 PST 
Created attachment 450329 [details]
Add unit tests that were left out of original patch for landing
Comment 14 EWS 2022-01-29 21:22:42 PST 
Committed r288796 (246573@main): <https://commits.webkit.org/246573@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450329 [details].