Bug 233882 – REGRESSION (r286527): Three API tests crashing under WebKit::ProcessLauncher::launchProcess()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Ryan Haddad]

Created attachment 446052 [details]
crash log

The following three API tests are crashing on iOS and macOS debug gots after https://trac.webkit.org/changeset/286527/webkit landed

TestWebKitAPI.WKNavigation.FailureToStartWebProcessAfterCrashRecovery
TestWebKitAPI.WKNavigation.FailureToStartWebProcessRecovery
TestWebKitAPI.WebKit.NetworkProcessRelaunchOnLaunchFailure

Thread 0 Crashed:
0   libxpc.dylib                  	0x00000001870b9ff8 0x187094000 + 155640
1   libxpc.dylib                  	0x0000000187099fa0 0x187094000 + 24480
2   libxpc.dylib                  	0x0000000187099da4 0x187094000 + 23972
3   com.apple.WebKit              	0x000000010e40d008 WebKit::ProcessLauncher::launchProcess()::$_0::operator()(NSObject<OS_xpc_object>*) const + 200 (ProcessLauncherCocoa.mm:256)
4   com.apple.WebKit              	0x000000010e40cf34 WebKit::ProcessLauncher::launchProcess()::$_1::operator()(NSObject<OS_xpc_object>*)::'lambda'()::operator()() const + 56 (ProcessLauncherCocoa.mm:281)
5   com.apple.WebKit              	0x000000010e40ce0c WTF::Detail::CallableWrapper<WebKit::ProcessLauncher::launchProcess()::$_1::operator()(NSObject<OS_xpc_object>*)::'lambda'(), void>::call() + 28 (Function.h:53)
6   com.apple.JavaScriptCore      	0x00000001040e8a3c WTF::Function<void ()>::operator()() const + 124 (Function.h:82)
7   com.apple.JavaScriptCore      	0x0000000104179088 WTF::RunLoop::performWork() + 316 (RunLoop.cpp:133)
8   com.apple.JavaScriptCore      	0x000000010417de54 WTF::RunLoop::performWork(void*) + 44 (RunLoopCF.cpp:46)

[Radar WebKit Bug Importer]

<rdar://problem/86111726>

[Ryan Haddad]

Example of failing run:
https://build.webkit.org/#/builders/3/builds/5480/steps/17/logs/stdio

History:
https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.WKNavigation.FailureToStartWebProcessAfterCrashRecovery&test=TestWebKitAPI.WKNavigation.FailureToStartWebProcessRecovery&test=TestWebKitAPI.WebKit.NetworkProcessRelaunchOnLaunchFailure

[Brent Fulgham]

What is the point of EWS if it does not reveal these kinds of problems. "https://ews-build.webkit.org/#/builders/3/builds/61596" indicates all-clear for the patch.

[Ryan Haddad]

(In reply to Brent Fulgham from comment #3)
> What is the point of EWS if it does not reveal these kinds of problems.
> "https://ews-build.webkit.org/#/builders/3/builds/61596" indicates all-clear
> for the patch.
In this case, the macOS API test queue is testing release builds, and this is only affecting debug.

[Brent Fulgham]

Created attachment 446058 [details]
Patch

[Brent Fulgham]

Created attachment 446065 [details]
Patch

[Wenson Hsieh]

Comment on attachment 446065 [details]
Patch

rs=me

[EWS]

Committed r286563 (?): <https://commits.webkit.org/r286563>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446065 [details].