Bug 233879 - [GStreamer] test fast/mediastream/get-display-media-settings.html fails
Summary: [GStreamer] test fast/mediastream/get-display-media-settings.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-06 09:48 PST by Arcady Goldmints-Orlov
Modified: 2022-01-14 00:20 PST (History)
11 users (show)

See Also:

Attachments
Patch (7.60 KB, patch)
2021-12-22 06:30 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arcady Goldmints-Orlov 2021-12-06 09:48:59 PST 
The test fast/mediastream/get-display-media-settings.html has failed on GTK and WPE since its addition in r286491, because typeof settings.deviceId is "undefined". This is likely because the change in question added support for deviceId for the Cocoa and Mock platforms but not for GStreamer.
Comment 1 Philippe Normand 2021-12-22 06:30:46 PST 
Created attachment 447800 [details]
Patch
Comment 2 EWS 2021-12-23 00:47:26 PST 
Committed r287386 (245526@main): <https://commits.webkit.org/245526@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447800 [details].
Comment 3 Radar WebKit Bug Importer 2021-12-23 00:48:20 PST 
<rdar://problem/86842768>