RESOLVED FIXED Bug 233872
[LBSE] Handle RenderSVGRoot in all places that handle LegacyRenderSVGRoot 
https://bugs.webkit.org/show_bug.cgi?id=233872
Summary [LBSE] Handle RenderSVGRoot in all places that handle LegacyRenderSVGRoot
Nikolas Zimmermann
Reported 2021-12-06 06:04:45 PST
Now that RenderSVGRoot is available, we need to hook it into various places in WebCore, that currently handle LegacyRenderSVGRoot.
Attachments
Patch, v1 (22.19 KB, patch)
2021-12-10 03:28 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch, v2 (21.27 KB, patch)
2021-12-10 04:01 PST, Nikolas Zimmermann 		rbuis: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2021-12-10 03:28:41 PST
Created attachment 446704 [details] Patch, v1
Rob Buis
Comment 2 2021-12-10 03:33:20 PST
Comment on attachment 446704 [details] Patch, v1 View in context: https://bugs.webkit.org/attachment.cgi?id=446704&action=review > Source/WebCore/svg/SVGSVGElement.cpp:510 > + return { 0, 0, floatValueForLength(intrinsicWidth, 0), floatValueForLength(intrinsicHeight, 0) }; Since a lot of code is duplicated, can this be shared better?
Nikolas Zimmermann
Comment 3 2021-12-10 04:01:50 PST
Created attachment 446709 [details] Patch, v2
Nikolas Zimmermann
Comment 4 2021-12-10 04:19:58 PST
Committed r286843 (245076@trunk): <https://commits.webkit.org/245076@trunk>
Radar WebKit Bug Importer
Comment 5 2021-12-10 04:20:22 PST
<rdar://problem/86316766>
Note You need to log in before you can comment on or make changes to this bug.