Bug 233872 - [LBSE] Handle RenderSVGRoot in all places that handle LegacyRenderSVGRoot
Summary: [LBSE] Handle RenderSVGRoot in all places that handle LegacyRenderSVGRoot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
Depends on: 233863
Blocks: 90738 233873
  Show dependency tree / graph
 
Reported: 2021-12-06 06:04 PST by Nikolas Zimmermann
Modified: 2021-12-10 04:20 PST (History)
24 users (show)

See Also:

Attachments
Patch, v1 (22.19 KB, patch)
2021-12-10 03:28 PST, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch, v2 (21.27 KB, patch)
2021-12-10 04:01 PST, Nikolas Zimmermann 		rbuis: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2021-12-06 06:04:45 PST 
Now that RenderSVGRoot is available, we need to hook it into various places in WebCore, that currently handle LegacyRenderSVGRoot.
Comment 1 Nikolas Zimmermann 2021-12-10 03:28:41 PST 
Created attachment 446704 [details]
Patch, v1
Comment 2 Rob Buis 2021-12-10 03:33:20 PST 
Comment on attachment 446704 [details]
Patch, v1

View in context: https://bugs.webkit.org/attachment.cgi?id=446704&action=review

> Source/WebCore/svg/SVGSVGElement.cpp:510
> +        return { 0, 0, floatValueForLength(intrinsicWidth, 0), floatValueForLength(intrinsicHeight, 0) };

Since a lot of code is duplicated, can this be shared better?
Comment 3 Nikolas Zimmermann 2021-12-10 04:01:50 PST 
Created attachment 446709 [details]
Patch, v2
Comment 4 Nikolas Zimmermann 2021-12-10 04:19:58 PST 
Committed r286843 (245076@trunk): <https://commits.webkit.org/245076@trunk>
Comment 5 Radar WebKit Bug Importer 2021-12-10 04:20:22 PST 
<rdar://problem/86316766>