Bug 233864 – webpushd/webpushtool debugging additions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brady Eidson]

webpushd/webpushtool debugging additions

Add more debug messages.
Add ability for webpushtool to reconnect when connection is lost.

[Brady Eidson]

Created attachment 445994 [details]
Patch v1

[Alex Christensen]

Comment on attachment 445994 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=445994&action=review

> Source/WebKit/ChangeLog:14
> +        * WebKit.xcodeproj/xcshareddata/xcschemes/webpushd.xcscheme: Added.

why?

> Source/WebKit/webpushd/PushClientConnection.mm:115
> +        messageIdentifier = makeString ("[(0x", hex((uint64_t)(m_xpcConnection.get()), WTF::HexConversionMode::Lowercase), ")] ");

reinterpret_cast

> Source/WebKit/webpushd/PushClientConnection.mm:117
> +        messageIdentifier = makeString ("[", signingIdentifer, " (0x", hex((uint64_t)(m_xpcConnection.get()), WTF::HexConversionMode::Lowercase), ")] ");

ditto

> Source/WebKit/webpushd/WebPushDaemon.mm:184
> +    broadcastDebugMessage((JSC::MessageLevel)0, makeString("New connection: 0x", hex((uint64_t)connection, WTF::HexConversionMode::Lowercase)));

JSC::MessageLevel::Log

> Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:39
> +enum class PreferTestService {

: bool

> Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:44
> +enum class Reconnect {

: bool

[Brady Eidson]

Created attachment 446079 [details]
PFL v1

[Brady Eidson]

The style check failure is a bogus bug because of how the string I'm constructing looks. Bummer.

[EWS]

ChangeLog entry in Tools/ChangeLog contains OOPS!.

[Brady Eidson]

Created attachment 446090 [details]
PFL v2

[EWS]

Committed r286579 (?): <https://commits.webkit.org/r286579>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446090 [details].

[Radar WebKit Bug Importer]

<rdar://problem/86130115>