Bug 233850 - [LFC][IFC] Compute isFirstBox/isLastBox for text content
Summary: [LFC][IFC] Compute isFirstBox/isLastBox for text content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-03 19:12 PST by zalan
Modified: 2021-12-04 08:52 PST (History)
5 users (show)

See Also:

Attachments
Patch (11.62 KB, patch)
2021-12-03 19:27 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.82 KB, patch)
2021-12-03 21:09 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.90 KB, patch)
2021-12-03 22:00 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.53 KB, patch)
2021-12-04 06:46 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-12-03 19:12:39 PST 
Iterators use these bits to figure out renderer boundaries.
Comment 1 zalan 2021-12-03 19:27:37 PST 
Created attachment 445937 [details]
Patch
Comment 2 zalan 2021-12-03 21:09:56 PST 
Created attachment 445955 [details]
Patch
Comment 3 zalan 2021-12-03 22:00:21 PST 
Created attachment 445956 [details]
Patch
Comment 4 Antti Koivisto 2021-12-04 05:37:09 PST 
Comment on attachment 445956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445956&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:394
> +        enum class LineHasFirstLastRunForTextBox { No, FirstOnly, LastOnly, Both };

Don't you have a few types for this already like IsFirstLastBox and OptionSet<InlineDisplay::Box::PositionWithinInlineLevelBox>?
Comment 5 zalan 2021-12-04 06:46:43 PST 
Created attachment 445970 [details]
Patch
Comment 6 EWS 2021-12-04 08:51:46 PST 
Committed r286534 (244866@main): <https://commits.webkit.org/244866@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445970 [details].
Comment 7 Radar WebKit Bug Importer 2021-12-04 08:52:24 PST 
<rdar://problem/86053206>