RESOLVED FIXED 233845
Add command line `webpushtool` for daemon development and debugging 
https://bugs.webkit.org/show_bug.cgi?id=233845
Summary Add command line `webpushtool` for daemon development and debugging
Brady Eidson
Reported 2021-12-03 16:44:28 PST
Add command line `webpushtool` for daemon development and debugging
Attachments
EWS v1 (29.08 KB, patch)
2021-12-03 17:10 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
EWS v2 (29.10 KB, patch)
2021-12-03 17:51 PST, Brady Eidson 		thorton: review+
DetailsFormatted DiffDiff
PFL v1 (30.49 KB, patch)
2021-12-03 18:34 PST, Brady Eidson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
PFL v2 (30.58 KB, patch)
2021-12-03 18:50 PST, Brady Eidson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
PFL v3 (30.59 KB, patch)
2021-12-03 19:51 PST, Brady Eidson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
PFL v4 (30.64 KB, patch)
2021-12-03 20:44 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
PFL v5 (different approach from v4) (30.63 KB, patch)
2021-12-03 20:55 PST, Brady Eidson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
PFL v6 (30.72 KB, patch)
2021-12-03 23:43 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2021-12-03 17:10:59 PST
Created attachment 445928 [details] EWS v1
Tim Horton
Comment 2 2021-12-03 17:20:55 PST
Comment on attachment 445928 [details] EWS v1 View in context: https://bugs.webkit.org/attachment.cgi?id=445928&action=review > Source/WebKit/Configurations/webpushtool.xcconfig:30 > + I think you need to sort out your INSTALL_PATH > Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm:38 > + fprintf(stderr, " --Development Connects to mach service \"org.webkit.webpushtestdaemon.service\" (Default)\n"); Really, leading-capitals in your command line arguments??
Brady Eidson
Comment 3 2021-12-03 17:51:45 PST
Created attachment 445934 [details] EWS v2
Brady Eidson
Comment 4 2021-12-03 18:34:29 PST
Created attachment 445935 [details] PFL v1
Brady Eidson
Comment 5 2021-12-03 18:50:23 PST
Created attachment 445936 [details] PFL v2
Brady Eidson
Comment 6 2021-12-03 19:51:28 PST
Created attachment 445941 [details] PFL v3
Brady Eidson
Comment 7 2021-12-03 20:44:00 PST
Created attachment 445952 [details] PFL v4
Brady Eidson
Comment 8 2021-12-03 20:55:12 PST
Created attachment 445954 [details] PFL v5 (different approach from v4)
Brady Eidson
Comment 9 2021-12-03 23:43:20 PST
Created attachment 445962 [details] PFL v6
EWS
Comment 10 2021-12-04 08:09:04 PST
Committed r286533 (244865@main): <https://commits.webkit.org/244865@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445962 [details].
Radar WebKit Bug Importer
Comment 11 2021-12-04 08:10:26 PST
<rdar://problem/86052852>
Note You need to log in before you can comment on or make changes to this bug.