Bug 233836 - REGRESSION(r285210)[GLIB][GStreamer] http/tests/media/media-blocked-by-willsendrequest.html is timing out
Summary: REGRESSION(r285210)[GLIB][GStreamer] http/tests/media/media-blocked-by-willse...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-03 12:13 PST by Lauro Moura
Modified: 2023-02-01 03:54 PST (History)
15 users (show)

See Also:


Attachments
Tentative patch (1.73 KB, patch)
2021-12-03 17:27 PST, Lauro Moura
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Updated patch fixing the directive (1.70 KB, patch)
2021-12-03 19:59 PST, Lauro Moura
calvaris: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-12-03 12:13:31 PST
http/tests/media/media-blocked-by-willsendrequest.html

Locally it was crashing alongside other WPT failures due to bug232629, but given a workaround for the crash was landed recently, now its timeout can be properly investigated/tracked.

Looks like r285210 removed a check that was supposed to affect only Cocoa but it made Soup-based ports to fail too.

Patch incoming.
Comment 1 Lauro Moura 2021-12-03 17:27:47 PST
Created attachment 445932 [details]
Tentative patch
Comment 2 Lauro Moura 2021-12-03 19:59:33 PST
Created attachment 445946 [details]
Updated patch fixing the directive
Comment 3 Lauro Moura 2021-12-05 18:11:44 PST
In the GTK EWS it caught this regression:

imported/w3c/web-platform-tests/content-security-policy/media-src/media-src-redir-bug.sub.html

--- /home/lauro/dev/WebKit/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/media-src/media-src-redir-bug.sub-expected.txt
+++ /home/lauro/dev/WebKit/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/media-src/media-src-redir-bug.sub-actual.txt
@@ -7,9 +7,9 @@
 
 Harness Error (TIMEOUT), message = null
 
-NOTRUN In-policy async video src
+FAIL In-policy async video src assert_unreached: Media error handler shouldn't be triggered for allowed domain. Reached unreachable code
 NOTRUN in-policy async video src w/redir
-NOTRUN In-policy async video source element
+FAIL In-policy async video source element assert_unreached: Media error handler shouldn't be triggered for allowed domain. Reached unreachable code
 NOTRUN In-policy async video source element w/redir
 NOTRUN Should not fire policy violation events
 This test tests a buggy interaction in Chrome 46. Two hosts (self and www2) are both allowed as media-src, but only one (self) is allowed for connect-src. If a video src starts on an allowed host (self), and is redirected to another allowed media-src host, it should succeed. But a bug causes the redirect to be done in a fetch context to which connect-src is being applied instead, so the load is blocked. (This test passes in Firefox 45, modulo an event listener not firing.)
Comment 4 Diego Pino 2023-02-01 03:53:57 PST
This test has been consistenly passing for many revisions now:

https://results.webkit.org/?suite=layout-tests&test=imported/w3c/web-platform-tests/dom/xslt/strip-space-crash.xml&platform=GTK&platform=WPE&platform=mac&platform=ios

Removed test from TestExpectations in https://commits.webkit.org/259674@main.

Closing bug.
Comment 5 Radar WebKit Bug Importer 2023-02-01 03:54:26 PST
<rdar://problem/104909851>