Bug 233834 – JSErrorHandler should not set window.event if invocation target is in shadow tree

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Alexey Shvayka]

JSErrorHandler should not set window.event if invocation target is in shadow tree

[Alexey Shvayka]

Created attachment 445886 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Ryosuke Niwa]

Comment on attachment 445886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445886&action=review

> LayoutTests/imported/w3c/ChangeLog:9
> +        * web-platform-tests/dom/events/event-global-expected.txt:
> +        * web-platform-tests/dom/events/event-global.html:

Is this merging upstream change? Or are you making a WPT change? It's unclear from the change log.

[Alexey Shvayka]

(In reply to Ryosuke Niwa from comment #3)

Thanks Ryosuke!

> Is this merging upstream change? Or are you making a WPT change? It's
> unclear from the change log.

We are exporting the tests; I will make sure to note that in ChangeLog.

[Ryosuke Niwa]

(In reply to Alexey Shvayka from comment #4)
> (In reply to Ryosuke Niwa from comment #3)
> 
> Thanks Ryosuke!
> 
> > Is this merging upstream change? Or are you making a WPT change? It's
> > unclear from the change log.
> 
> We are exporting the tests; I will make sure to note that in ChangeLog.

Okay, in that case, please be sure to land WPT side of change first.

[Radar WebKit Bug Importer]

<rdar://problem/86333697>

[Alexey Shvayka]

Committed r286871 (245102@trunk): <https://commits.webkit.org/245102@trunk>