Bug 233834 - JSErrorHandler should not set window.event if invocation target is in shadow tree
Summary: JSErrorHandler should not set window.event if invocation target is in shadow ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Trivial
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-03 11:54 PST by Alexey Shvayka
Modified: 2021-12-10 14:23 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.15 KB, patch)
2021-12-03 11:55 PST, Alexey Shvayka 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2021-12-03 11:54:26 PST 
JSErrorHandler should not set window.event if invocation target is in shadow tree
Comment 1 Alexey Shvayka 2021-12-03 11:55:18 PST 
Created attachment 445886 [details]
Patch
Comment 2 EWS Watchlist 2021-12-03 11:56:26 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Ryosuke Niwa 2021-12-03 17:33:31 PST 
Comment on attachment 445886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445886&action=review

> LayoutTests/imported/w3c/ChangeLog:9
> +        * web-platform-tests/dom/events/event-global-expected.txt:
> +        * web-platform-tests/dom/events/event-global.html:

Is this merging upstream change? Or are you making a WPT change? It's unclear from the change log.
Comment 4 Alexey Shvayka 2021-12-03 18:11:29 PST 
(In reply to Ryosuke Niwa from comment #3)

Thanks Ryosuke!

> Is this merging upstream change? Or are you making a WPT change? It's
> unclear from the change log.

We are exporting the tests; I will make sure to note that in ChangeLog.
Comment 5 Ryosuke Niwa 2021-12-03 23:52:14 PST 
(In reply to Alexey Shvayka from comment #4)
> (In reply to Ryosuke Niwa from comment #3)
> 
> Thanks Ryosuke!
> 
> > Is this merging upstream change? Or are you making a WPT change? It's
> > unclear from the change log.
> 
> We are exporting the tests; I will make sure to note that in ChangeLog.

Okay, in that case, please be sure to land WPT side of change first.
Comment 6 Radar WebKit Bug Importer 2021-12-10 11:55:19 PST 
<rdar://problem/86333697>
Comment 7 Alexey Shvayka 2021-12-10 13:24:51 PST 
Committed r286871 (245102@trunk): <https://commits.webkit.org/245102@trunk>