Bug 233833 - Extend the scope where the Window's current event is set
Summary: Extend the scope where the Window's current event is set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Trivial
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-03 11:51 PST by Alexey Shvayka
Modified: 2021-12-10 13:29 PST (History)
7 users (show)

See Also:


Attachments
Patch (9.96 KB, patch)
2021-12-03 11:52 PST, Alexey Shvayka
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2021-12-03 11:51:04 PST
Extend the scope where the Window's current event is set
Comment 1 Alexey Shvayka 2021-12-03 11:52:49 PST
Created attachment 445885 [details]
Patch
Comment 2 EWS Watchlist 2021-12-03 11:54:18 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Ryosuke Niwa 2021-12-03 17:37:31 PST
Comment on attachment 445885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445885&action=review

> LayoutTests/imported/w3c/ChangeLog:13
> +        * web-platform-tests/dom/events/event-global-is-still-set-when-coercing-beforeunload-result-expected.txt: Added.
> +        * web-platform-tests/dom/events/event-global-is-still-set-when-coercing-beforeunload-result.html: Added.
> +        * web-platform-tests/dom/events/event-global-set-before-handleEvent-lookup.any-expected.txt: Added.
> +        * web-platform-tests/dom/events/event-global-set-before-handleEvent-lookup.any.html: Added.
> +        * web-platform-tests/dom/events/event-global-set-before-handleEvent-lookup.any.js: Added.
> +        * web-platform-tests/dom/events/resources/event-global-is-still-set-when-coercing-beforeunload-result-frame.html: Added.

Are these test getting imported? Or are we adding new tests? Please clarify in the change log.
Comment 4 Alexey Shvayka 2021-12-03 18:17:24 PST
(In reply to Ryosuke Niwa from comment #3)

Thank you for review!

> Are these test getting imported? Or are we adding new tests?

Yea, we are adding new tests.

> Please clarify in the change log.

Will do.
Comment 5 Ryosuke Niwa 2021-12-03 23:52:49 PST
(In reply to Alexey Shvayka from comment #4)
> (In reply to Ryosuke Niwa from comment #3)
> 
> Thank you for review!
> 
> > Are these test getting imported? Or are we adding new tests?
> 
> Yea, we are adding new tests.

Okay, again, please land WPT change first.
Comment 6 Radar WebKit Bug Importer 2021-12-10 11:52:19 PST
<rdar://problem/86333564>
Comment 7 Alexey Shvayka 2021-12-10 13:28:50 PST
Committed r286873 (245103@trunk): <https://commits.webkit.org/245103@trunk>