Bug 233830 - [JSC] Add LLInt IC for try_get_by_id of own cacheable value
Summary: [JSC] Add LLInt IC for try_get_by_id of own cacheable value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-03 11:07 PST by Ross Kirsling
Modified: 2021-12-07 17:45 PST (History)
8 users (show)

See Also:

Attachments
Patch (7.19 KB, patch)
2021-12-03 11:15 PST, Ross Kirsling 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (7.15 KB, patch)
2021-12-03 13:48 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (10.33 KB, patch)
2021-12-07 16:01 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2021-12-03 11:07:37 PST 
[JSC] Add LLInt IC for try_get_by_id of own cacheable value
Comment 1 Ross Kirsling 2021-12-03 11:15:24 PST 
Created attachment 445877 [details]
Patch
Comment 2 Ross Kirsling 2021-12-03 13:48:13 PST 
Created attachment 445894 [details]
Patch

rebased
Comment 3 Yusuke Suzuki 2021-12-07 15:04:56 PST 
Comment on attachment 445894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445894&action=review

> Source/JavaScriptCore/bytecode/BytecodeList.rb:526
> +        structureID: StructureID,

StructureID is heap pointer (somewhat). So you need to consider about GC.
So, you need to add handling to CodeBlock::finalizeLLIntInlineCaches.
Comment 4 Yusuke Suzuki 2021-12-07 15:10:31 PST 
Comment on attachment 445894 [details]
Patch

Looks good overall, but I think we have GC issue, so r- for now.
Comment 5 Ross Kirsling 2021-12-07 16:01:21 PST 
Created attachment 446247 [details]
Patch
Comment 6 Yusuke Suzuki 2021-12-07 16:03:44 PST 
Comment on attachment 446247 [details]
Patch

r=me
Comment 7 EWS 2021-12-07 17:44:45 PST 
Committed r286635 (244948@main): <https://commits.webkit.org/244948@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446247 [details].
Comment 8 Radar WebKit Bug Importer 2021-12-07 17:45:21 PST 
<rdar://problem/86185467>