Bug 233823 - Fix playstation build after r286484
Summary: Fix playstation build after r286484
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Other Other
: P2 Normal
Assignee: ujwal koneru
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-03 10:17 PST by ujwal koneru
Modified: 2021-12-03 15:22 PST (History)
3 users (show)

See Also:


Attachments
[fast-cq]Patch for build fix (1.78 KB, patch)
2021-12-03 11:52 PST, ujwal koneru
no flags Details | Formatted Diff | Diff
[fast-cq]Patch for build fix (1.75 KB, patch)
2021-12-03 12:46 PST, ujwal koneru
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
[fast-cq]Patch for build fix (1.79 KB, patch)
2021-12-03 14:35 PST, ujwal koneru
no flags Details | Formatted Diff | Diff
[fast-cq]Patch for build fix (1.75 KB, text/plain)
2021-12-03 14:37 PST, ujwal koneru
no flags Details
[fast-cq]Patch for build fix (2.55 KB, patch)
2021-12-03 15:06 PST, ujwal koneru
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ujwal koneru 2021-12-03 10:17:38 PST
Apply changes in logging  r286484 after to Source/WebKit/UIProcess/playstation/WebProcessPoolPlayStation.cpp 
https://build.webkit.org/#/builders/65/builds/9853/steps/8/logs/stdio
Comment 1 ujwal koneru 2021-12-03 11:52:22 PST
Created attachment 445884 [details]
[fast-cq]Patch for build fix

Remove the logging parameters that were changed in header.
Comment 2 ujwal koneru 2021-12-03 12:46:54 PST
Created attachment 445890 [details]
[fast-cq]Patch for build fix
Comment 3 EWS 2021-12-03 13:10:52 PST
Tools/Scripts/svn-apply failed to apply attachment 445890 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 4 Ross Kirsling 2021-12-03 13:14:01 PST
Comment on attachment 445890 [details]
[fast-cq]Patch for build fix

View in context: https://bugs.webkit.org/attachment.cgi?id=445890&action=review

> Source/WebKit/UIProcess/playstation/WebProcessPoolPlayStation.cpp:43
> -void WebProcessPool::platformInitializeWebProcess(const WebProcessProxy&, WebProcessCreationParameters& parameters)
> +void WebProcessPool::platformInitializeWebProcess(const WebProcessProxy&, WebProcessCreationParameters& )

When you reupload, you should also remove the space before the end paren here.
(You could also remove the extra newline for the body if you want.)
Comment 5 ujwal koneru 2021-12-03 14:35:19 PST
Created attachment 445899 [details]
[fast-cq]Patch for build fix
Comment 6 ujwal koneru 2021-12-03 14:37:06 PST
Created attachment 445901 [details]
[fast-cq]Patch for build fix
Comment 7 ujwal koneru 2021-12-03 15:06:06 PST
Created attachment 445907 [details]
[fast-cq]Patch for build fix

Added logging back in webprocess(https://trac.webkit.org/changeset/286484/webkit/trunk/Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp). For webprocess pool, parent when initialized, handles logging(https://trac.webkit.org/changeset/286484/webkit/trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.cpp).
Comment 8 EWS 2021-12-03 15:21:21 PST
Committed r286517 (244852@main): <https://commits.webkit.org/244852@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445907 [details].
Comment 9 Radar WebKit Bug Importer 2021-12-03 15:22:23 PST
<rdar://problem/86036592>