Bug 233792 - [Cocoa] Web Inspector: fix completion handler type signature for _WKInspectorExtension methods
Summary: [Cocoa] Web Inspector: fix completion handler type signature for _WKInspector...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-02 16:47 PST by BJ Burg
Modified: 2021-12-03 09:36 PST (History)
4 users (show)

See Also:


Attachments
Patch v1.0 (5.32 KB, patch)
2021-12-02 17:06 PST, BJ Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2021-12-02 16:47:54 PST
A dictionary is not necessarily returned here, the implementation deserializes a SerializedScriptValue. While the frontend does return a dictionary payload, this is unpacked on the WebProcess-side before being sent back out via the _WKInspectorExtension APi.
Comment 1 Radar WebKit Bug Importer 2021-12-02 16:48:16 PST
<rdar://problem/85995314>
Comment 2 BJ Burg 2021-12-02 17:06:12 PST
Created attachment 445796 [details]
Patch v1.0
Comment 3 Devin Rousso 2021-12-02 17:09:23 PST
Comment on attachment 445796 [details]
Patch v1.0

rs=me
Comment 4 EWS 2021-12-03 09:36:14 PST
Committed r286497 (244836@main): <https://commits.webkit.org/244836@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445796 [details].