Bug 233790 - AX: Make ellipsis-text.html, aria-roledescription.html, and aria-switch-checked.html pass in isolated tree mode
Summary: AX: Make ellipsis-text.html, aria-roledescription.html, and aria-switch-check...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-02 16:29 PST by Tyler Wilcock
Modified: 2021-12-04 07:23 PST (History)
10 users (show)

See Also:

Attachments
Patch (12.27 KB, patch)
2021-12-02 16:33 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (14.02 KB, patch)
2021-12-03 08:13 PST, Tyler Wilcock 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.01 KB, patch)
2021-12-03 14:43 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2021-12-02 16:29:40 PST 
aria-roledescription.html and aria-switch-checked.html must be made async to pass in isolated tree mode as they dynamically change page content using JS.

ellipsis-text.html can be made isolated-tree-friendly by selecting elements with accessibleElementById instead of:

document.getElementById("text-ellipsis").focus();
var textContainer = accessibilityController.focusedElement;
Comment 1 Radar WebKit Bug Importer 2021-12-02 16:29:58 PST 
<rdar://problem/85994654>
Comment 2 Tyler Wilcock 2021-12-02 16:33:44 PST 
Created attachment 445789 [details]
Patch
Comment 3 Tyler Wilcock 2021-12-03 08:10:46 PST 
Need to upload a new patch. GTK has a different default role description, so my new version of aria-roledescription.html fails there.
Comment 4 Tyler Wilcock 2021-12-03 08:13:09 PST 
Created attachment 445856 [details]
Patch
Comment 5 Tyler Wilcock 2021-12-03 14:43:42 PST 
Created attachment 445903 [details]
Patch
Comment 6 EWS 2021-12-04 07:23:04 PST 
Committed r286530 (244862@main): <https://commits.webkit.org/244862@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445903 [details].