Bug 233783 – Regression(r283179) Google Drive freezes after downloading a folder

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Google Drive freezes after downloading a folder since r283179.

[Chris Dumez]

<rdar://85918531>

[Chris Dumez]

Created attachment 445773 [details]
Patch

[Darin Adler]

Comment on attachment 445773 [details]
Patch

Regression test?

[Chris Dumez]

(In reply to Darin Adler from comment #3)
> Comment on attachment 445773 [details]
> Patch
> 
> Regression test?

Hmm. Maybe if I add an SPI to ask if the layer tree is frozen or not. I'll look into that.

[Geoffrey Garen]

r=me

Would this behavior be simpler if we fired decidePolicyForNavigationResponse before parsing the COOP header and trying to load in a separate process? It seems a little round-about to receive the response, launch a new process, *and then* ask the client if that's what it wanted.

[Chris Dumez]

(In reply to Geoffrey Garen from comment #5)
> r=me
> 
> Would this behavior be simpler if we fired decidePolicyForNavigationResponse
> before parsing the COOP header and trying to load in a separate process? It
> seems a little round-about to receive the response, launch a new process,
> *and then* ask the client if that's what it wanted.

The reason this was done this way is that decidePolicyForNavigationResponse() currently comes from the WebProcess to the UIProcess and contains the network resource. For security reasons, we do not want the old process to see the response from the navigated-to page that has opted into COOP and caused a process-swap.

In the future, we may want to consider doing decidePolicyForNavigationResponse() directly from the network process to the UIProcess. We would also need to have the UIProcess trigger the download instead of sending PolicyAction::Download to the WebProcess.

[Chris Dumez]

Will look into adding an API test tomorrow via Bug 233798.

[EWS]

Committed r286479 (244818@main): <https://commits.webkit.org/244818@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445773 [details].