Bug 233772 – MessageChannel::port1() / port2() should return references instead of pointers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

MessageChannel::port1() / port2() should return references instead of pointers.

[Chris Dumez]

Created attachment 445738 [details]
Patch

[Chris Dumez]

Created attachment 445740 [details]
Patch

[Chris Dumez]

Created attachment 445742 [details]
Patch

[Chris Dumez]

Created attachment 445760 [details]
Patch

[EWS]

Committed r286453 (244795@main): <https://commits.webkit.org/244795@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445760 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85989068>

[Darin Adler]

Comment on attachment 445760 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445760&action=review

> Source/WebCore/dom/MessageChannel.h:43
> +    MessagePort& port1() const { return m_ports.first.get(); }
> +    MessagePort& port2() const { return m_ports.second.get(); }

I think the get() calls here are optional. Probably compiles and works without them.

[Chris Dumez]

(In reply to Darin Adler from comment #7)
> Comment on attachment 445760 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=445760&action=review
> 
> > Source/WebCore/dom/MessageChannel.h:43
> > +    MessagePort& port1() const { return m_ports.first.get(); }
> > +    MessagePort& port2() const { return m_ports.second.get(); }
> 
> I think the get() calls here are optional. Probably compiles and works
> without them.

Indeed, fixed it via <https://commits.webkit.org/r286456>. Thanks.