WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 233753
[libpas] Define and use PAS_RISCV
https://bugs.webkit.org/show_bug.cgi?id=233753
Summary
[libpas] Define and use PAS_RISCV
Zan Dobersek
Reported
2021-12-02 01:03:21 PST
[libpas] Define and use PAS_RISCV
Attachments
Patch
(4.48 KB, patch)
2021-12-02 01:03 PST
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Patch
(4.51 KB, patch)
2021-12-02 03:11 PST
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2021-12-02 01:03:38 PST
Created
attachment 445688
[details]
Patch
Zan Dobersek
Comment 2
2021-12-02 03:11:24 PST
Created
attachment 445698
[details]
Patch
Yusuke Suzuki
Comment 3
2021-12-02 07:13:02 PST
Comment on
attachment 445698
[details]
Patch r=me
EWS
Comment 4
2021-12-02 07:46:11 PST
Committed
r286429
(
244775@main
): <
https://commits.webkit.org/244775@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 445698
[details]
.
Radar WebKit Bug Importer
Comment 5
2021-12-02 07:47:26 PST
<
rdar://problem/85970966
>
Filip Pizlo
Comment 6
2021-12-02 13:39:53 PST
Comment on
attachment 445698
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=445698&action=review
> Source/bmalloc/libpas/src/libpas/pas_segregated_page_inlines.h:372 > -#if !PAS_ARM > +#if !PAS_ARM && !PAS_RISCV
This code should probably really be saying "#if PAS_X86". But it's fine for now since there are so few places where we have to worry about it.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug