Bug 233751 - Improve dictionary-based DOMPromiseDeferred::settle
Summary: Improve dictionary-based DOMPromiseDeferred::settle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 233523
Blocks:
  Show dependency tree / graph
 
Reported: 2021-12-01 23:36 PST by youenn fablet
Modified: 2021-12-03 09:36 PST (History)
2 users (show)

See Also:

Attachments
Patch (9.67 KB, patch)
2021-12-01 23:57 PST, youenn fablet 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-12-01 23:36:12 PST 
Improve dictionary-based DOMPromiseDeferred::settle
Comment 1 youenn fablet 2021-12-01 23:57:46 PST 
Created attachment 445680 [details]
Patch
Comment 2 Chris Dumez 2021-12-03 07:22:43 PST 
Comment on attachment 445680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445680&action=review

r=me

> Source/WebCore/ChangeLog:9
> +        Update call sites that use settle for non ExceptionOr types as they shouldeither use reject or resolve directly.

typo: shouldeither
Comment 3 Chris Dumez 2021-12-03 09:35:36 PST 
Committed r286496 (244835@main): <https://commits.webkit.org/244835@main>
Comment 4 Radar WebKit Bug Importer 2021-12-03 09:36:22 PST 
<rdar://problem/86021792>