RESOLVED FIXED 233749
move shouldAutoActivateFontIfNeeded knownFamilies cache to FontCache 
https://bugs.webkit.org/show_bug.cgi?id=233749
Summary move shouldAutoActivateFontIfNeeded knownFamilies cache to FontCache
Cameron McCormack (:heycam)
Reported 2021-12-01 23:09:30 PST
With OffscreenCanvas, we can call shouldAutoActivateFontIfNeeded on a worker thread, and the knownFamilies HashSet is not thread safe. Also, the AtomStrings it stores are thread-specific. Move it to FontCache, so each thread has its own set.
Attachments
Patch with dependencies for EWS (61.47 KB, patch)
2021-12-01 23:10 PST, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (3.62 KB, patch)
2021-12-01 23:11 PST, Cameron McCormack (:heycam) 		mmaxfield: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
[fast-cq] Patch for landing (3.65 KB, patch)
2021-12-07 17:18 PST, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2021-12-01 23:10:38 PST
Created attachment 445675 [details] Patch with dependencies for EWS
Cameron McCormack (:heycam)
Comment 2 2021-12-01 23:11:56 PST
Created attachment 445676 [details] Patch
Myles C. Maxfield
Comment 3 2021-12-07 00:47:12 PST
Comment on attachment 445676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445676&action=review Good idea. > Source/WebCore/platform/graphics/FontCache.h:378 > +#if PLATFORM(MAC) I think generally our policy is to only ifdef function definitions, not declarations (just to reduce visual noise).
Myles C. Maxfield
Comment 4 2021-12-07 00:47:54 PST
It's probably worth investigating whether this cache actually saves us any perf at all.
Cameron McCormack (:heycam)
Comment 5 2021-12-07 13:16:15 PST
(In reply to Myles C. Maxfield from comment #3) > I think generally our policy is to only ifdef function definitions, not > declarations (just to reduce visual noise). OK. I guess it would need to be #ifdefed it were using some platform-specific type (and we didn't already have a typedef pointing to the platform-specific type we could use). There is some benefit from the #ifdef, which is to point out to the reader that these are indeed only available on some platform/configuration, but maybe they can just discover that themselves when they try to call the function and it's not defined everywhere.
EWS
Comment 6 2021-12-07 17:09:46 PST
/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Cameron McCormack (:heycam)
Comment 7 2021-12-07 17:18:58 PST
Created attachment 446261 [details] [fast-cq] Patch for landing
EWS
Comment 8 2021-12-07 17:36:57 PST
Committed r286634 (?): <https://commits.webkit.org/r286634> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446261 [details].
Radar WebKit Bug Importer
Comment 9 2021-12-07 17:38:41 PST
<rdar://problem/86185239>
Note You need to log in before you can comment on or make changes to this bug.