The Win32 port of Threading does not have this implemented and we need it now for MessageQueue::waitForMessageTimed. The code we have is borrowed from early version of boost/pthreads-win32. I'm bringing their later revision with timedWait. See comment in ThreadingWin.cpp file for more info and related links.
Created attachment 26782 [details] Proposed patch Only affects Win32 code. Built on mac and win. Run workers and storage layout tests on win (those actually use threading and don't depend on font metrics :-).
The patch looks good to me. I'm going to apply it to my local tree and try it out.
(In reply to comment #2) > The patch looks good to me. I'm going to apply it to my local tree and try it out. FYI -- It builds and runs find in my local Cairo-based Windows build.
Created attachment 26876 [details] irc_chat.txt Additional info on license use: asking questions on webkit-dev and on IRC indicates the usage of 2 licenses in a single file is ok. It is not necessary, but nice to include the lust of pthread-win32 contributors which is referred by their license. See http://www.nabble.com/Using-LGPL-derived-source-in-one-of-the-wtf-files.-td21550637.html and attached file irc_chat.txt
Created attachment 26877 [details] Proposed patch, v2 Added CONTRIBUTORS and fixed couple of style issues.
Created attachment 26901 [details] review notes (in IRC) addressed - renamed CONTRIBUTORS to CONTRIBUTORS.pthreads-win32 - updated ChangeLog - removed '::' for Win32 APIs - build release on Win, no warnings. Not sure where to use ASSERT_UNUSED.
Comment on attachment 26901 [details] review notes (in IRC) addressed r=me Perhaps MSVC doesn't warn about unused variable, or maybe we have that warning disabled.
Committed revision 40122.