Bug 233695 - GraphicsContextGLANGLE should not have Cocoa Mac specific display reconfiguration code
Summary: GraphicsContextGLANGLE should not have Cocoa Mac specific display reconfigura...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: gcgranglecleanup
  Show dependency treegraph
 
Reported: 2021-12-01 04:28 PST by Kimmo Kinnunen
Modified: 2021-12-02 06:16 PST (History)
13 users (show)

See Also:


Attachments
Patch (33.28 KB, patch)
2021-12-01 04:43 PST, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (33.30 KB, patch)
2021-12-01 05:03 PST, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (33.24 KB, patch)
2021-12-01 05:29 PST, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (33.30 KB, patch)
2021-12-01 05:47 PST, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (34.62 KB, patch)
2021-12-02 00:50 PST, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (34.45 KB, patch)
2021-12-02 02:32 PST, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-12-01 04:28:25 PST
GraphicsContextGLANGLE should not have Cocoa Mac specific display reconfiguration code
Comment 1 Kimmo Kinnunen 2021-12-01 04:43:10 PST
Created attachment 445557 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-12-01 05:03:29 PST
Created attachment 445560 [details]
Patch
Comment 3 Kimmo Kinnunen 2021-12-01 05:29:04 PST
Created attachment 445563 [details]
Patch
Comment 4 Kimmo Kinnunen 2021-12-01 05:47:15 PST
Created attachment 445566 [details]
Patch
Comment 5 Kimmo Kinnunen 2021-12-02 00:50:07 PST
Created attachment 445687 [details]
Patch
Comment 6 Kimmo Kinnunen 2021-12-02 02:32:10 PST
Created attachment 445697 [details]
Patch
Comment 7 Antti Koivisto 2021-12-02 05:09:16 PST
Comment on attachment 445697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445697&action=review

> Source/WebCore/platform/graphics/mac/DisplayConfigurationMonitor.h:53
> +    Vector<Client*> m_clients;

This could use CheckedPtr for safety (by inheriting Client from CanMakeCheckedPtr).
Comment 8 EWS 2021-12-02 06:15:38 PST
Committed r286423 (244769@main): <https://commits.webkit.org/244769@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445697 [details].
Comment 9 Radar WebKit Bug Importer 2021-12-02 06:16:38 PST
<rdar://problem/85968513>