WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 233695
GraphicsContextGLANGLE should not have Cocoa Mac specific display reconfiguration code
https://bugs.webkit.org/show_bug.cgi?id=233695
Summary
GraphicsContextGLANGLE should not have Cocoa Mac specific display reconfigura...
Kimmo Kinnunen
Reported
2021-12-01 04:28:25 PST
GraphicsContextGLANGLE should not have Cocoa Mac specific display reconfiguration code
Attachments
Patch
(33.28 KB, patch)
2021-12-01 04:43 PST
,
Kimmo Kinnunen
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(33.30 KB, patch)
2021-12-01 05:03 PST
,
Kimmo Kinnunen
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(33.24 KB, patch)
2021-12-01 05:29 PST
,
Kimmo Kinnunen
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(33.30 KB, patch)
2021-12-01 05:47 PST
,
Kimmo Kinnunen
no flags
Details
Formatted Diff
Diff
Patch
(34.62 KB, patch)
2021-12-02 00:50 PST
,
Kimmo Kinnunen
no flags
Details
Formatted Diff
Diff
Patch
(34.45 KB, patch)
2021-12-02 02:32 PST
,
Kimmo Kinnunen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(5)
View All
Add attachment
proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1
2021-12-01 04:43:10 PST
Created
attachment 445557
[details]
Patch
Kimmo Kinnunen
Comment 2
2021-12-01 05:03:29 PST
Created
attachment 445560
[details]
Patch
Kimmo Kinnunen
Comment 3
2021-12-01 05:29:04 PST
Created
attachment 445563
[details]
Patch
Kimmo Kinnunen
Comment 4
2021-12-01 05:47:15 PST
Created
attachment 445566
[details]
Patch
Kimmo Kinnunen
Comment 5
2021-12-02 00:50:07 PST
Created
attachment 445687
[details]
Patch
Kimmo Kinnunen
Comment 6
2021-12-02 02:32:10 PST
Created
attachment 445697
[details]
Patch
Antti Koivisto
Comment 7
2021-12-02 05:09:16 PST
Comment on
attachment 445697
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=445697&action=review
> Source/WebCore/platform/graphics/mac/DisplayConfigurationMonitor.h:53 > + Vector<Client*> m_clients;
This could use CheckedPtr for safety (by inheriting Client from CanMakeCheckedPtr).
EWS
Comment 8
2021-12-02 06:15:38 PST
Committed
r286423
(
244769@main
): <
https://commits.webkit.org/244769@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 445697
[details]
.
Radar WebKit Bug Importer
Comment 9
2021-12-02 06:16:38 PST
<
rdar://problem/85968513
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug