Bug 233694 - [GTK][a11y] Add implementation of table and table cell interfaces when building with ATSPI
Summary: [GTK][a11y] Add implementation of table and table cell interfaces when buildi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: ATSPI
  Show dependency tree / graph
 
Reported: 2021-12-01 04:25 PST by Carlos Garcia Campos
Modified: 2021-12-02 00:16 PST (History)
11 users (show)

See Also:

Attachments
Patch (75.61 KB, patch)
2021-12-01 04:29 PST, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-12-01 04:25:49 PST 
Implement table and table cell
Comment 1 Carlos Garcia Campos 2021-12-01 04:29:13 PST 
Created attachment 445554 [details]
Patch
Comment 2 Adrian Perez 2021-12-01 05:45:44 PST 
Comment on attachment 445554 [details]
Patch

Other than changing a few pointer literals to “nulptr” before landing, patch LGTM.


View in context: https://bugs.webkit.org/attachment.cgi?id=445554&action=review

> Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1069
> +        return JSStringCreateWithCharacters(0, 0);

While changing this you could replace the first zero with nullptr:

    return JSStringCreateWithCharacters(nullptr, 0);

=]

> Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1078
> +        return JSStringCreateWithCharacters(0, 0);

Same here: s/0/nullptr

> Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1092
> +        return JSStringCreateWithCharacters(0, 0);

...and here...

> Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1101
> +        return JSStringCreateWithCharacters(0, 0);

...one more...

> Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1146
> +        return JSStringCreateWithCharacters(0, 0);

...and another...

(okay, I will stop commenting now on each of those)
Comment 3 Carlos Garcia Campos 2021-12-02 00:16:25 PST 
Committed r286416 (244762@main): <https://commits.webkit.org/244762@main>