Bug 233693 - [JSC] Fix potential build break related to StructureID.h
Summary: [JSC] Fix potential build break related to StructureID.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-01 03:31 PST by Xan Lopez
Modified: 2021-12-01 12:52 PST (History)
9 users (show)

See Also:

Attachments
v1 (1.46 KB, patch)
2021-12-01 03:32 PST, Xan Lopez 		no flags Details | Formatted Diff | Diff
v2 (1.46 KB, patch)
2021-12-01 03:37 PST, Xan Lopez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2021-12-01 03:31:43 PST 
The file is now using CPURegister without declaring it. This may or may not just compile because of unified builds, but it broke at least one build: https://build.webkit.org/#/builders/133/builds/4298/steps/9/logs/stdio
Comment 1 Xan Lopez 2021-12-01 03:32:51 PST 
Created attachment 445547 [details]
v1

Add include for CPURegister.
Comment 2 Xan Lopez 2021-12-01 03:37:21 PST 
Created attachment 445548 [details]
v2

Now with the right include!
Comment 3 EWS 2021-12-01 04:45:48 PST 
Committed r286360 (244719@main): <https://commits.webkit.org/244719@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445548 [details].
Comment 4 Radar WebKit Bug Importer 2021-12-01 04:46:25 PST 
<rdar://problem/85917211>
Comment 5 Keith Miller 2021-12-01 12:52:31 PST 
Whoops, thanks!