Bug 233691 - [WebGPU] Add default values to structs in WebCore/Modules/WebGPU
Summary: [WebGPU] Add default values to structs in WebCore/Modules/WebGPU
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 233624 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-12-01 00:51 PST by Myles C. Maxfield
Modified: 2021-12-01 16:32 PST (History)
2 users (show)

See Also:

Attachments
Patch (30.83 KB, patch)
2021-12-01 00:52 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-12-01 00:51:29 PST 
[WebGPU] Add default values to structs in WebCore/Modules/WebGPU
Comment 1 Myles C. Maxfield 2021-12-01 00:52:32 PST 
Created attachment 445539 [details]
Patch
Comment 2 Myles C. Maxfield 2021-12-01 04:24:34 PST 
*** Bug 233624 has been marked as a duplicate of this bug. ***
Comment 3 Alex Christensen 2021-12-01 14:55:07 PST 
Comment on attachment 445539 [details]
Patch

Definitely an improvement.  I'm still concerned about all those raw pointers.  Can they be WeakPtr instead?
Comment 4 Myles C. Maxfield 2021-12-01 16:01:22 PST 
(In reply to Alex Christensen from comment #3)
> Comment on attachment 445539 [details]
> Patch
> 
> Definitely an improvement.  I'm still concerned about all those raw
> pointers.  Can they be WeakPtr instead?

They're not stored though... 🤔
Comment 5 EWS 2021-12-01 16:31:08 PST 
Committed r286403 (244750@main): <https://commits.webkit.org/244750@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445539 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-01 16:32:28 PST 
<rdar://problem/85945191>