Bug 233671 - REGRESSION (r283431): Fix NEAR_FIELD macro for iOS
Summary: REGRESSION (r283431): Fix NEAR_FIELD macro for iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: pascoe@apple.com
URL:
Keywords: InRadar
Depends on: 231085
Blocks:
  Show dependency tree / graph
 
Reported: 2021-11-30 16:56 PST by pascoe@apple.com
Modified: 2021-12-01 11:01 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2021-11-30 17:16 PST, pascoe@apple.com 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description pascoe@apple.com 2021-11-30 16:56:16 PST 
In https://bugs.webkit.org/show_bug.cgi?id=231085

The near field macro got changed from #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR)) to #if PLATFORM(MAC) && !PLATFORM(IOS_FAMILY_SIMULATOR).


The latter disables NEAR_FIELD for all iOS devices, breaking WebAuthn with NFC.
Comment 1 pascoe@apple.com 2021-11-30 16:56:22 PST 
rdar://85318070
Comment 2 pascoe@apple.com 2021-11-30 17:16:29 PST 
Created attachment 445491 [details]
Patch
Comment 3 Brent Fulgham 2021-12-01 10:24:50 PST 
Comment on attachment 445491 [details]
Patch

r=me
Comment 4 EWS 2021-12-01 11:01:42 PST 
Committed r286370 (244729@main): <https://commits.webkit.org/244729@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445491 [details].