Bug 23367 – Increase range of values that can be represented by JSImmediate on 64-bit platforms.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

Increase range of values that can be represented by JSImmediate on 64-bit platforms.

[Gavin Barraclough]

Created attachment 26776 [details]
The patch

[Geoffrey Garen]

Comment on attachment 26776 [details]
The patch


> +    addSlowCase(emitJumpIfEitherNumber(X86::ecx));

Let's call this "emitJumpIfImmediateNumber".

> +                emitJumpSlowCaseIfNotImmediateIntegerNumber(X86::eax);

Let's call "*IntegerNumber" "*Integer".


-    , numberStructure(JSNumberCell::createStructure(jsNull()))
+    , numberStructure(createNumberStructure(jsNull()))

You could just use NULL or 0xbbadbeef here in 64bit, since we shouldn't be using the JSNumberCell structure on 64bit. Not a big deal, though.

+     * C++'s idea of a reinterpret_cast lacks sufficient cojones.
+     */
+    template<typename TO, typename FROM>
+    TO wtf_reinterpret_cast(FROM in)

Let's put this in wtf/StdLibExtras.h, in the WTF namespace. Then, we can remove the "wtf_" prefix. Maybe we should call this "union_cast."

+    inline JSValuePtr JSImmediate::makeOutOfIntegerRange(T value)

How about calling this "fromOutOfRangeInteger".

r=me

[Gavin Barraclough]

fixed in r39958