Bug 233658 – [ Monterey ] fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html (layout-test) is a constant text failure

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Robert Jenner]

fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html

is a constant text failure on Monterey. 

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fimages%2Ftext-recognition%2Fmac%2Fimage-overlay-text-disables-app-highlight-menu-items.html

DIFF URL:
https://build.webkit.org/results/Apple-Monterey-Release-WK2-Tests/r286311%20(292)/fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items-pretty-diff.html

TEXT DIFF:
-PASS foundTitle1 is true
-PASS foundTitle2 is true
-PASS Selected image overlay
-PASS foundTitle1 is false
-PASS foundTitle2 is false
-PASS successfullyParsed is true
+CONSOLE MESSAGE: TypeError: undefined is not an object (evaluating 'internals.appHighlightContextMenuItemTitles')
+FAIL successfullyParsed should be true. Was false.
+Some tests failed.
 
 TEST COMPLETE
-
+ Hello world this is a test.

[Radar WebKit Bug Importer]

<rdar://problem/85886424>

[Wenson Hsieh]

> +CONSOLE MESSAGE: TypeError: undefined is not an object (evaluating
> 'internals.appHighlightContextMenuItemTitles')
> +FAIL successfullyParsed should be true. Was false.

This test is passing in configurations where ENABLE_APP_HIGHLIGHTS is defined.

I'm guessing we just need to upstream ENABLE_APP_HIGHLIGHTS code.

[Wenson Hsieh]

Created attachment 445642 [details]
For EWS

[Wenson Hsieh]

Created attachment 445750 [details]
Fix iOS build

[Wenson Hsieh]

(In reply to Wenson Hsieh from comment #2)
> > +CONSOLE MESSAGE: TypeError: undefined is not an object (evaluating
> > 'internals.appHighlightContextMenuItemTitles')
> > +FAIL successfullyParsed should be true. Was false.
> 
> This test is passing in configurations where ENABLE_APP_HIGHLIGHTS is
> defined.
> 
> I'm guessing we just need to upstream ENABLE_APP_HIGHLIGHTS code.

Verified with a non-internal macOS Monterey WebKit build that this is the only change needed to fix the test.

[Wenson Hsieh]

Comment on attachment 445750 [details]
Fix iOS build

Thanks for the review!

[EWS]

Committed r286450 (244792@main): <https://commits.webkit.org/244792@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445750 [details].