233648 – Move Subspaces from VM to Heap.

Bug 233648 - Move Subspaces from VM to Heap.

Summary: Move Subspaces from VM to Heap.

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	JavaScriptCore (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Mark Lam

URL:
Keywords:	InRadar

Depends on:
Blocks:	232849
	Show dependency tree / graph

Attachments
proposed patch. (420.51 KB, patch) 2021-11-30 14:06 PST, Mark Lam	saam: review+ ews-feeder: commit-queue-	Details \| Formatted Diff \| Diff
patch for landing. (421.16 KB, patch) 2021-11-30 14:52 PST, Mark Lam	ews-feeder: commit-queue-	Details \| Formatted Diff \| Diff
patch for landing + speculative fix for Windows build. (421.54 KB, patch) 2021-11-30 16:18 PST, Mark Lam	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mark Lam 2021-11-30 11:16:11 PST

Subspaces are Heap data structures to begin with, and this refactoring is needed in preparation for the global GC.

Comment 1 Radar WebKit Bug Importer 2021-11-30 11:17:12 PST

<rdar://problem/85875751>

Comment 2 Mark Lam 2021-11-30 14:06:03 PST

Created attachment 445469 [details]
proposed patch.

Comment 3 Saam Barati 2021-11-30 14:44:06 PST

Comment on attachment 445469 [details]
proposed patch.

r=me

Comment 4 Mark Lam 2021-11-30 14:52:32 PST

Created attachment 445472 [details]
patch for landing.

Thanks for the review.  This patch also includes a fix for the watchOS EWS build failure.

Comment 5 Mark Lam 2021-11-30 16:18:29 PST

Created attachment 445484 [details]
patch for landing + speculative fix for Windows build.

Comment 6 Mark Lam 2021-11-30 20:39:56 PST

Landed in r286347: <http://trac.webkit.org/r286347>.