Bug 233632 - [GTK][WPE] Build fails as of r286287 when manually configuring a build with CMake
Summary: [GTK][WPE] Build fails as of r286287 when manually configuring a build with C...
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-30 04:41 PST by Adrian Perez
Modified: 2021-11-30 06:39 PST (History)
0 users

See Also:


Attachments
Patch (1.53 KB, patch)
2021-11-30 05:00 PST, Adrian Perez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2021-11-30 04:41:24 PST
Build fails with:

---- 8< ---------- 8< ---------- 8< ---------- 8< ----

/home/aperez/devel/WebKit/Source/WebCore/style/RuleFeature.cpp:258:43: error: unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'?
            if constexpr (!std::is_same_v<nullptr_t, decltype(hostAffectingNames)>) {
                                          ^~~~~~~~~
                                          std::nullptr_t
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/11.1.0/../../../../include/c++/11.1.0/x86_64-pc-linux-gnu/bits/c++config.h:284:29: note: 'std::nullptr_t' declared here
  typedef decltype(nullptr)     nullptr_t;
                                ^

---- 8< ---------- 8< ---------- 8< ---------- 8< ----

This is a WPE build targeting x86_64 configured with:

  cmake -S. -Bbuild-wpe -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo \
    -DENABLE_EXPERIMENTAL_FEATURES=ON -DUSE_SOUP2=OFF

The same build issue happens when trying to build the GTK port.
Comment 1 Adrian Perez 2021-11-30 05:00:07 PST
Created attachment 445408 [details]
Patch
Comment 2 EWS 2021-11-30 06:35:33 PST
Tools/Scripts/svn-apply failed to apply attachment 445408 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 3 Adrian Perez 2021-11-30 06:39:14 PST
Fixed by philn in r286226, he was faster than me :)