Bug 233619 - [WebGPU] Hook up navigator.gpu.requestAdapter()
Summary: [WebGPU] Hook up navigator.gpu.requestAdapter()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 233534 (view as bug list)
Depends on: 233600
Blocks: 233622
  Show dependency treegraph
 
Reported: 2021-11-29 21:58 PST by Myles C. Maxfield
Modified: 2021-12-02 15:38 PST (History)
6 users (show)

See Also:


Attachments
Patch (34.25 KB, patch)
2021-11-29 22:12 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (36.20 KB, patch)
2021-11-30 13:57 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-11-29 21:58:56 PST
Hook up navigator.gpu.requestAdapter()
Comment 1 Myles C. Maxfield 2021-11-29 22:12:53 PST
Created attachment 445381 [details]
Patch
Comment 2 Myles C. Maxfield 2021-11-29 22:19:24 PST
*** Bug 233534 has been marked as a duplicate of this bug. ***
Comment 3 Myles C. Maxfield 2021-11-29 23:29:31 PST
With this patch, we have enough for the first function call !!! v.excited
Comment 4 Myles C. Maxfield 2021-11-29 23:42:59 PST
Comment on attachment 445381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445381&action=review

> Source/WebCore/page/WorkerNavigator.cpp:51
> +    // FIXME: Implement this.

https://bugs.webkit.org/show_bug.cgi?id=233622
Comment 5 Myles C. Maxfield 2021-11-30 13:57:44 PST
Created attachment 445468 [details]
Patch
Comment 6 Dean Jackson 2021-12-02 14:58:34 PST
Comment on attachment 445468 [details]
Patch

Can we test this?
Comment 7 Myles C. Maxfield 2021-12-02 15:00:39 PST
(In reply to Dean Jackson from comment #6)
> Comment on attachment 445468 [details]
> Patch
> 
> Can we test this?

We can! But Apple has to get its internal build system set up first. As soon as that happens I'll add the test.

Yay!!!!
Comment 8 EWS 2021-12-02 15:37:26 PST
Committed r286459 (244800@main): <https://commits.webkit.org/244800@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445468 [details].
Comment 9 Radar WebKit Bug Importer 2021-12-02 15:38:23 PST
<rdar://problem/85992595>